Fix busestrace not collecting sensor minidumps on boot trace stop#180
Open
murphyryanmicrosoft wants to merge 1 commit intomasterfrom
Open
Fix busestrace not collecting sensor minidumps on boot trace stop#180murphyryanmicrosoft wants to merge 1 commit intomasterfrom
murphyryanmicrosoft wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue that causes busestrace to not collect sensor minidumps on boot trace stop.
Two bugs prevented minidump collection when stopping a boot session trace:
profileName is not set when the user selects 'Stop Boot Session Trace' from the main menu (it is only set when starting a new trace via the profile selection menu). The profileName gate at CollectDispDiag therefore always fell through to SkipCollectDispDiag, skipping minidump collection entirely. Fixed by also entering CollectDispDiag when profileName is empty (boot trace stop path).
miniDumpCollectionScript used a relative path for the 'if exist' check, so it would fail if the user's current directory differed from the script directory. Fixed by prepending scriptDirectory.