fix(librsvg2): resolve BR-unresolvable nightly build failure#17636
Open
WithEnoughCoffee wants to merge 1 commit into
Open
fix(librsvg2): resolve BR-unresolvable nightly build failure#17636WithEnoughCoffee wants to merge 1 commit into
WithEnoughCoffee wants to merge 1 commit into
Conversation
WithEnoughCoffee
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the librsvg2 component to make Koji nightly builds succeed by avoiding buildroot-unresolvable Rust dependency chains and removing reliance on Fedora-only packaging.
Changes:
- Force vendored (bundled) Rust dependencies to avoid dynamic BuildRequires generation that pulls in unavailable crates.
- Replace the Fedora
rust-toolsetBuildRequires withcargo-rpm-macrosfor Azure Linux. - Update rendered spec output / lock fingerprint to reflect the component changes.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
base/comps/librsvg2/librsvg2.comp.toml |
Adds overlays to enable bundled Rust deps and replace rust-toolset BR; keeps AVIF disabled in %build. |
specs/l/librsvg2/librsvg2.spec |
Rendered spec reflects the overlay effects plus rpmautospec release/changelog updates. |
locks/librsvg2.lock |
Updates input fingerprint after component config change. |
Add overlays to resolve buildroot resolution failure (mock exit 30) in Koji nightly builds (taskID 2590970): - Enable bundled Rust dependencies (%global bundled_rust_deps 1) to avoid dynamic crate BRs that pull in unpackaged dav1d via rust-image+avif-native - Replace rust-toolset BR with cargo-rpm-macros (AZL does not ship the Fedora rust-toolset metapackage) - Unconditionally disable AVIF support (-Davif=disabled) since dav1d system libraries are not available in AZL4 Build and smoke-test verified in mock chroot.
WithEnoughCoffee
force-pushed
the
fix/librsvg2-br-unresolvable
branch
from
63c4aef to
f9b5ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add overlays to resolve buildroot resolution failure (mock exit 30) in Koji nightly builds (taskID 2590970).
Changes
%global bundled_rust_deps 1) to avoid dynamic crate BRs that pull in unpackaged dav1d via rust-image+avif-nativerust-toolsetBR withcargo-rpm-macros(AZL does not ship the Fedora rust-toolset metapackage)-Davif=disabled) since dav1d system libraries are not available in AZL4Testing
rsvg-convert --versionruns correctly (v2.61.0)References