fix(python-build): disable tests/extras bconds to fix BR-unresolvable nightly failure#17635
Open
WithEnoughCoffee wants to merge 1 commit into
Open
fix(python-build): disable tests/extras bconds to fix BR-unresolvable nightly failure#17635WithEnoughCoffee wants to merge 1 commit into
WithEnoughCoffee wants to merge 1 commit into
Conversation
01cd2eb to
2a47071
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Azure Linux component configurations and their rendered specs to address Koji nightly buildroot resolution failures by reducing dynamic/unavailable BuildRequires (notably around Rust crates/AVIF for librsvg2, and extras/tests dependency discovery for python-build).
Changes:
librsvg2: enable bundled Rust deps, drop Fedorarust-toolsetBR, and force AVIF disabled in%build.python-build: introduce a dedicated component config disablingextras/testsbconds to avoid non-deterministic BR resolution, and update lock/rendered outputs accordingly.- Update rendered specs/sidecar macros and lock fingerprint to match the new component configuration.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/librsvg2/librsvg2.comp.toml |
Adds overlays to vendor Rust deps and adjust BRs/meson flags for AZL. |
specs/l/librsvg2/librsvg2.spec |
Rendered spec reflecting the new librsvg2 overlay effects (bundled deps/BR changes/AVIF disabled). |
base/comps/python-build/python-build.comp.toml |
Adds a dedicated component file disabling extras/tests to avoid dynamic BR scheduling issues. |
locks/python-build.lock |
Updates input fingerprint due to component config change. |
specs/p/python-build/python-build.spec |
Rendered python-build spec now loading the generated macros and carrying the updated changelog/release. |
specs/p/python-build/python-build.azl.macros |
New azldev-generated macros sidecar implementing build.without toggles. |
base/comps/components.toml |
Removes python-build from the inline “unmodified” component list since it’s now customized via a dedicated comp file. |
Comment on lines
+99
to
+100
| * Fri May 29 2026 Autumn Nash <autumnnash@microsoft.com> - 1.3.0-6 | ||
| - python-build: disable tests bcond to fix BR-unresolvable nightly failure |
e33811e to
6d55064
Compare
…able nightly failure The tests bcond (enabled by default when %rhel is undefined) causes %pyproject_buildrequires -g test to generate dynamic BuildRequires for test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that may not be published in the Koji build tag at build time, resulting in mock exit status 30 (BR-unresolvable). The extras bcond pulls uv into BuildRequires via %pyproject_buildrequires -x virtualenv,uv. The uv package currently fails to build in AZL4, causing cascading BR-unresolvable failures. Disable both via build.without, aligning with RHEL behavior as the spec was designed for. The %pyproject_check_import basic sanity check still runs. Fixes: Koji task 2593995 Related: AB#20330
6d55064 to
7fc5b82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable
testsandextrasbconds for python-build to resolve buildroot resolution failure (mock exit 30) in Koji nightly builds (taskID 2593995).Problem
The
testsbcond (enabled by default when%rhelis undefined) causes%pyproject_buildrequires -g testto generate dynamic BuildRequires for test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that may not be published in the Koji build tag at build time.Fix
Add
build.without = ["extras", "tests"]— aligning with RHEL behavior. The%pyproject_check_importbasic sanity check still runs.Testing
%pyproject_check_importpassesReferences