Allow custom HTTP client for Connection#122
Open
adamconnelly wants to merge 1 commit intomicrosoft:devfrom
Open
Allow custom HTTP client for Connection#122adamconnelly wants to merge 1 commit intomicrosoft:devfrom
adamconnelly wants to merge 1 commit intomicrosoft:devfrom
Conversation
I've added the ability to specify a custom HTTP client when creating a Connection. This is important because the various Azure DevOps clients make requests during construction to get the resource area info. This meant that some requests would be made with the default HTTP client even when specifying a custom one for the git client.
Contributor
|
@adamconnelly please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree company="Spacelift" |
|
@nechvatalp - can you please take a quick look? this PR's been open for 2 years and it's not even complex |
|
or @apudovkin-ms 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the ability to specify a custom HTTP client when creating a Connection. This is important because the various Azure DevOps clients make requests during construction to get the resource area info. This meant that some requests would be made with the default HTTP client even when specifying a custom one for the git client.