Bring recent fixes up to 2026-06-04#6
Merged
Merged
Conversation
azure-cli 2.87.0 wired zone-movement into 'az vm update' (Azure/ azure-cli#33242). The new PUT body trips a BadRequest from regions/ subs where zone movement isn't enabled, breaking our tag flip. Switch to 'az tag update', which hits the generic ARM tag endpoint and doesn't touch the Compute provider. Verified live on a westus2 Standard_D2s_v5 ACL VM with az 2.87.0. ---- #### AI description (iteration 1) #### PR Classification Bug fix to resolve Azure VM provisioning failures during SELinux toggle tests by switching from a VM-specific update command to a generic ARM tag update endpoint. #### PR Summary This PR fixes Azure VM provisioning failures caused by unsupported zone movement operations when setting IMDS tags during SELinux testing. The fix changes the tag update mechanism to avoid round-tripping the entire VM resource through the Compute RP, which was triggering the incompatibility error. - `run-selinux-toggle-test.sh`: Replaced `az vm update` commands with `az tag update` using the generic ARM tag endpoint to modify the `acl-node-security-profile` tag - `run-selinux-toggle-test.sh`: Added VM resource ID retrieval via `az vm show` to support the new tag update approach - `run-selinux-toggle-test.sh`: Changed tag deletion to use `--operation delete` and tag setting to use `--operation merge` for more targeted updates <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #20481
…on Azure The etcd project has declared the public v2 discovery service no longer maintained (https://etcd.io/blog/2025/announcing-etcd-3.6/). Add platforms:[azure] exceptions for: - acl.etcd-member.discovery - acl.flannel.udp - acl.flannel.vxlan - cl.etcd-member.v2-backup-restore Related work items: #20438
add irqbalance pkg in base image for ACL. Please check the https://dev.azure.com/mariner-org/ACL/_workitems/edit/20485/ for analysis. Signed-off-by: Mayank Singh <mayansingh@microsoft.com> Related work items: #20485
There was a problem hiding this comment.
Pull request overview
This PR brings a small set of operational/test reliability updates into the repo: it improves how an Azure VM tag is updated for the SELinux toggle test, exempts Azure runs for kola tests that depend on discovery.etcd.io, and includes irqbalance in the RPM-mode base package set.
Changes:
- Add
irqbalanceto the RPM package catalog’s base system package set. - Update the SELinux toggle test to use
az tag update(ARM tag endpoint) instead ofaz vm updatewhen setting/removing the VM tag. - Exempt specific
discovery.etcd.io-dependent kola enforcing tests from running on Azure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build_library/rpm/package_catalog.yaml | Adds irqbalance to the base RPM package set (via the sys-apps/systemd pull-in list). |
| acl/tests/run-selinux-toggle-test.sh | Switches VM tagging to az tag update for more robust tag operations. |
| acl/tests/kola_enforcing.yaml | Adds Azure exceptions for tests that rely on discovery.etcd.io. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nbojanic
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing recent fixes to the GitHub repo.
az tag updatein SELinux toggle test