Add workflow to validate published Aspire CLI builds#17532
Draft
radical wants to merge 4 commits into
Draft
Conversation
The daily CLI smoke workflow only ran classes matching *SmokeTests and installed the dev daily channel by default. That left most CLI end-to-end coverage out of the daily signal and did not exercise the staging channel. Change the workflow dispatch default to staging, enumerate the CLI E2E class-split matrix, and run each test class as its own matrix job. The matrix jobs load the prebuilt CLI E2E Docker images and pass ASPIRE_E2E_QUALITY through so the tests install the requested daily channel instead of using source-built CLI artifacts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The daily workflow runs outside pull request events, so the CLI E2E project is skipped during test enumeration unless the workflow explicitly overrides that skip. Without this, the generated class matrix is empty even though the workflow asks to include CLI E2E tests. Pass SkipTests=false when building the daily matrix so the CLI E2E project emits its class partitions for the staging daily workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The full CLI E2E validation should run as a post-publish check instead of expanding the scheduled daily smoke workflow. Daily smoke stays focused on its small smoke-test subset, while validate-published-build enumerates the same class-split CLI E2E matrix used by PR validation and runs each class as its own GitHub Actions job against the selected install-script quality. Wire the internal Azure DevOps build to dispatch the new workflow after the WinGet and Homebrew installer preparation jobs complete. The trigger reuses the existing GitHub App dispatch helper from the release pipeline, maps stable installer builds to the release quality and prerelease builds to the staging quality, and waits for the GitHub Actions run to finish. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the published-build validation branch back to a GitHub-only change by removing the Azure DevOps dispatch wiring from this branch. The new workflow remains manually dispatchable and validates an exact published Aspire CLI version, with the CLI E2E tests split by class to match PR validation shape. Harden the workflow based on self-review by avoiding direct template expansion in shell scripts, disabling checkout credential persistence during matrix setup, and preserving the MTP no-tests exit-code handling used by the main test runner. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17532Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17532" |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 2 jobs were identified as retry-safe transient failures in the CI run attempt.
Matched test failure patterns (1 test)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a manually-dispatchable GitHub Actions workflow for validating a published Aspire CLI build with the full CLI E2E suite.
The existing daily smoke workflow stays small. This new workflow is the GitHub-side validation target for a later release/AzDO dispatch change: it accepts an exact Aspire CLI
version, enumerates the sameAspire.Cli.EndToEnd.Testsclass-split matrix used by PR validation, and runs each class as its own GitHub Actions job.The workflow builds and loads the shared CLI E2E Docker images, installs the exact requested Aspire CLI version through the existing E2E install strategy, excludes quarantined and outerloop tests, and keeps the Microsoft.Testing.Platform no-tests exit-code handling used by the main test runner.
The workflow was hardened with pinned actions,
contents: read, disabled checkout credential persistence, and env-based shell inputs to avoid direct template expansion in scripts.Validation:
Local matrix generation confirmed 64
Aspire.Cli.EndToEnd.Testsclass entries.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?