Bump StreamJsonRpc 2.22.23 -> 2.24.92 (needs Roslyn 4.14 analyzer workaround)#17516
Draft
joperezr wants to merge 1 commit into
Draft
Bump StreamJsonRpc 2.22.23 -> 2.24.92 (needs Roslyn 4.14 analyzer workaround)#17516joperezr wants to merge 1 commit into
joperezr wants to merge 1 commit into
Conversation
Deferred from #17056. StreamJsonRpc 2.24.x ships an analyzer that requires Roslyn 4.14, but the Templates tests build generated AppHost projects with the .NET 8 SDK (Roslyn 4.11), so all 16 Templates jobs fail with CS9057. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17516Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17516" |
Contributor
|
❓ CLI E2E Tests unknown — 107 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26481645175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Draft — will fail Templates CI. Posting this PR to coordinate the migration. Splitting it out of #17056 so the rest of the deferred dep bumps can land.
What's here
A single one-line bump in
Directory.Packages.props:Why this needs a focused PR
StreamJsonRpc 2.24.xships a Roslyn analyzer assembly (StreamJsonRpc.Analyzers.dll) compiled against Roslyn 4.14.0. The Templates tests build generated AppHost projects using the .NET 8 SDK (Roslyn 4.11.0). When the .NET 8 csc loads the StreamJsonRpc analyzer it fails with:All 16 Templates CI jobs fail with this error.
Options to investigate
<PackageReference ... ExcludeAssets="analyzers" />(or equivalent) to the templated project so the analyzer never loads under the legacy .NET 8 csc. This keeps the runtime/library bump but skips the build-time analyzer where the SDK is too old.Tagging @karolz-ms, @danegsta, @davidfowl — you've been closest to the DCP/StreamJsonRpc integration; could you pick the right path? Happy to do the implementation once we've agreed.
Related
Affected CI jobs (all Templates)