Fix non-interactive self-update channel selection by alirezafzali · Pull Request #17512 · microsoft/aspire

alirezafzali · 2026-05-26T22:13:46Z

Description

Fixes #15253

aspire update --self --non-interactive fails with an interactive prompt error when --channel is not provided.

This updates ExecuteSelfUpdateAsync so that in non-interactive mode:

If the CLI's identity channel maps to a known update channel (stable, daily, or staging), that channel is used (with canonical casing from the channel list).
If identity is local, the command defaults to stable.
If identity does not map to a known channel (e.g. stale pr-*), the command requires --channel instead of guessing.

Interactive mode still prompts for channel selection as before.

Added tests for:

Using a known CLI identity channel (daily/stable, including case-insensitive identity) without prompting in non-interactive mode
Defaulting to stable for local identity in non-interactive mode
Requiring --channel for stale/unmatched PR identity (pr-99999) in non-interactive mode
Explicit --channel overriding the identity channel in non-interactive mode

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds non-interactive self-update behavior to avoid channel prompts by inferring the update channel from the CLI’s identity channel (or defaulting to stable), with accompanying tests to validate the selection/override rules.

Changes:

Update self-update flow to skip channel prompting in --non-interactive mode and select a channel deterministically.
Prefer ExecutionContext.IdentityChannel when it matches a known update channel; otherwise default to stable.
Add unit tests covering identity-channel matching, local/stale identity channels defaulting, and explicit --channel override.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/Aspire.Cli.Tests/Commands/UpdateCommandTests.cs	Adds tests validating non-interactive self-update channel selection and override behavior.
src/Aspire.Cli/Commands/UpdateCommand.cs	Changes non-interactive self-update to bypass prompting and pick a channel based on identity/default logic.

alirezafzali · 2026-05-27T08:25:35Z

+                if (!string.IsNullOrWhiteSpace(identityChannel)
+                    && !string.Equals(identityChannel, PackageChannelNames.Local, StringComparisons.ChannelName)
+                    && channels.Any(c => string.Equals(c, identityChannel, StringComparisons.ChannelName)))
+                {
+                    channel = identityChannel;
+                }


Good catch. Updated ExecuteSelfUpdateAsync to use channels.FirstOrDefault(...) and assign matchedChannel so the channel string is normalized, consistent with the project-update identity path. Added [InlineData("DAILY", "daily")] to the non-interactive self-update tests.

alirezafzali · 2026-05-27T08:08:40Z

+        await result.InvokeAsync().DefaultTimeout();
+
+        Assert.False(promptForSelectionInvoked, "Identity-channel match should bypass the channel prompt.");
+        Assert.Equal(identityChannel, capturedChannel);


We don’t assert exit code Success on these self-update tests because we only fake the download with invalid archive bytes; extraction always fails afterward, so the process exits with an error even when channel selection worked. We assert the channel passed to the downloader (and MissingRequiredArgument when channel is required), same as TracksChannelParameter.

alirezafzali · 2026-05-27T08:20:47Z

+        var services = CliTestHelper.CreateServiceCollection(workspace, outputHelper, options =>
+        {
+            options.CliExecutionContextFactory = _ => workspace.CreateExecutionContext(identityChannel: PackageChannelNames.Local);
+
+            options.InteractionServiceFactory = _ => new TestInteractionService()
+            {
+                PromptForSelectionCallback = (prompt, choices, formatter, ct) =>
+                {
+                    promptForSelectionInvoked = true;
+                    return PackageChannelNames.Stable;
+                }
+            };
+
+            options.CliDownloaderFactory = _ => new TestCliDownloader(workspace.WorkspaceRoot)
+            {
+                DownloadLatestCliAsyncCallback = (channel, ct) =>
+                {
+                    capturedChannel = channel;
+                    var archivePath = Path.Combine(workspace.WorkspaceRoot.FullName, "test-cli.tar.gz");
+                    File.WriteAllText(archivePath, "fake archive");
+                    return Task.FromResult(archivePath);
+                }
+            };
+        });


Matches existing self-update tests (TracksChannelParameter, etc.). I can add RunSelfUpdateAndCaptureChannelAsync in a follow-up, or in this PR if maintainers want that refactor here.

github-actions · 2026-05-26T22:15:06Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17512

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17512"

JamesNK · 2026-05-26T23:24:54Z

@davidfowl @mitchdenny I'm not a channel expert. Does it make sense or is it possible to default the channel?

davidfowl · 2026-05-27T00:08:35Z

Yep this makes sense

JamesNK · 2026-05-27T00:13:26Z

@alirezafzali The one scenario I'm not sure about is this one:

Falling back to stable for stale PR identity (pr-99999) in non-interactive mode

I think there is also an argument to switching to nightly from a PR. Since there isn't an obvious choice, I think in this case the channel should be required.

…ution. Require --channel when identity does not map to a known update channel (e.g. stale pr-*), keep local defaulting to stable, and assign canonical channel names from the channels list for case-insensitive identity matches.

alirezafzali · 2026-05-27T08:27:08Z

@alirezafzali The one scenario I'm not sure about is this one:

Falling back to stable for stale PR identity (pr-99999) in non-interactive mode

I think there is also an argument to switching to nightly from a PR. Since there isn't an obvious choice, I think in this case the channel should be required.

Makes sense. I’ve changed this so stale/unmatched identities (e.g. pr-99999) require --channel in non-interactive mode instead of defaulting to stable. Known channels still auto-resolve from identity; local still falls back to stable.

Fix non-interactive self-update channel selection

7f1a6e0

Copilot AI review requested due to automatic review settings May 26, 2026 22:13

alirezafzali requested review from JamesNK, davidfowl and mitchdenny as code owners May 26, 2026 22:13

Copilot AI reviewed May 26, 2026

View reviewed changes

github-actions Bot mentioned this pull request May 27, 2026

[repo-pulse] 📊 Repo Pulse — Daily Activity Dashboard #16404

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix non-interactive self-update channel selection#17512

Fix non-interactive self-update channel selection#17512
alirezafzali wants to merge 2 commits into
microsoft:mainfrom
alirezafzali:fix/update-self-non-interactive-channel

alirezafzali commented May 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

alirezafzali May 27, 2026

Uh oh!

alirezafzali May 27, 2026

Uh oh!

alirezafzali May 27, 2026

Uh oh!

github-actions Bot commented May 26, 2026 •

edited

Loading

Uh oh!

JamesNK commented May 26, 2026

Uh oh!

davidfowl commented May 27, 2026

Uh oh!

JamesNK commented May 27, 2026

Uh oh!

alirezafzali commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alirezafzali commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

alirezafzali May 27, 2026

Choose a reason for hiding this comment

Uh oh!

alirezafzali May 27, 2026

Choose a reason for hiding this comment

Uh oh!

alirezafzali May 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamesNK commented May 26, 2026

Uh oh!

davidfowl commented May 27, 2026

Uh oh!

JamesNK commented May 27, 2026

Uh oh!

alirezafzali commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alirezafzali commented May 26, 2026 •

edited

Loading

github-actions Bot commented May 26, 2026 •

edited

Loading