-
Notifications
You must be signed in to change notification settings - Fork 74
[docs] Update aspire agent init docs for bundle-derived skill catalog (13.4) #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aspire-repo-bot
wants to merge
1
commit into
release/13.4
Choose a base branch
from
docs/agent-init-bundle-skills-13-4-1e06215fc85e126b
base: release/13.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phase A nuance + Phase B warning (line 27): the sentence "All catalog skills are pre-selected by default, except one-time workspace-wiring skills (such as
aspireify) that are omitted from the defaults when running against an existing project." reads as a universal rule but only applies to the standaloneaspire agent initcommand documented here.In
microsoft/aspirerelease/13.4@e258349fd:AgentInitCommand.cs:141-143— standalone agent init excludesaspireifyby default (matches this doc).InitCommand.cs:171-173—aspire init(which also runs against an existing repo) deliberately callsPromptAndChainAsyncwithout the exclusion predicate, soaspireifyIS pre-selected there. The source comment: "aspire init creates an AppHost in an existing repo, so pre-select every bundle skill (which includes aspireify as the natural follow-up wiring skill)."The aspire init docs page advertises this behavior too — it has a dedicated "The aspireify skill" section. A reader hopping between pages will see two different defaulting behaviors for the same "existing project" scenario.
Suggested wording: "In this standalone command, one-time workspace-wiring skills (such as
aspireify) are not pre-selected. Useaspire initto install the AppHost and pre-select aspireify together as part of that flow."