Bump JS deps to resolve all open Dependabot alerts#1648
Open
IEvangelist wants to merge 1 commit into
Open
Conversation
Closes the two open Dependabot alerts on this repo by bumping the two JavaScript lockfile-based manifests via npm \overrides\: | File | Package | Bumped to | Severity | GHSA | Alert | | --- | --- | --- | --- | --- | --- | | \samples/polyglot-task-queue/api/package-lock.json\ | \qs\ | \6.15.2\ | medium | GHSA-r2pq-mvjr-w5xj | #480 | | \samples/aspire-with-javascript/AspireJavaScript.Angular/package-lock.json\ | \webpack-dev-server\ | \5.2.4\ | medium | GHSA-79cf-xcqc-c78w | #474 | Both packages are transitive, so each is pinned via npm \overrides\ and the lockfile is regenerated with \ pm install --package-lock-only\. No direct dependency or top-level script is affected; the only behavioral change is the patched vulnerable transitives are no longer resolved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves the repo’s remaining open Dependabot alerts by pinning patched versions of two vulnerable transitive JavaScript dependencies via npm overrides, and updating the corresponding lockfiles to reflect the new resolutions.
Changes:
- Add an npm override for
qsinsamples/polyglot-task-queue/apiand updatepackage-lock.jsontoqs@6.15.2. - Extend the existing npm overrides in
samples/aspire-with-javascript/AspireJavaScript.Angularto forcewebpack-dev-server@^5.2.4and updatepackage-lock.jsontowebpack-dev-server@5.2.4(with related lockfile pruning).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| samples/polyglot-task-queue/api/package.json | Adds npm overrides entry to force qs to a patched version. |
| samples/polyglot-task-queue/api/package-lock.json | Updates resolved qs package entry to 6.15.2. |
| samples/aspire-with-javascript/AspireJavaScript.Angular/package.json | Adds webpack-dev-server to existing overrides to force patched version. |
| samples/aspire-with-javascript/AspireJavaScript.Angular/package-lock.json | Updates resolved webpack-dev-server to 5.2.4 and removes now-unneeded optional peer entries. |
Files not reviewed (2)
- samples/aspire-with-javascript/AspireJavaScript.Angular/package-lock.json: Language not supported
- samples/polyglot-task-queue/api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Drive-by validation comment - GitHub won't let me approve my own PR:
Ready for a maintainer review/merge once the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump JS deps to resolve all open Dependabot alerts
Summary
Closes the two open Dependabot alerts on this repo by bumping the two JavaScript lockfile-based manifests via npm
overrides.Alerts addressed
samples/polyglot-task-queue/api/package-lock.jsonqs< 6.15.26.15.2samples/aspire-with-javascript/AspireJavaScript.Angular/package-lock.jsonwebpack-dev-server<= 5.2.35.2.4How each manifest was updated
samples/polyglot-task-queue/api-qsis a transitive (viaexpress). Added anoverridesblock that pinsqsto^6.15.2, then regeneratedpackage-lock.jsonwithnpm install --package-lock-only. The diff is a one-line version + integrity bump.samples/aspire-with-javascript/AspireJavaScript.Angular-webpack-dev-serveris a transitive (via@angular-devkit/build-angular). Added an entry to the existingoverridesblock ("webpack-dev-server": "^5.2.4"), then regeneratedpackage-lock.jsonwithnpm install --package-lock-only --legacy-peer-deps(matching the existing lockfile generation; thetypescript@~6.0.3vs@angular-devkit/build-angularpeer-dep mismatch is pre-existing and unrelated). Only thewebpack-dev-serverpackage + a few transitively-removed@emnapi/*peer-optional entries change.Validation
For each updated manifest,
npm install --package-lock-only --no-audit --no-fundsucceeds against the configured mirror, and every vulnerable version is gone from the resolved tree:Risk notes for reviewers
webpack-dev-server 5.2.4is a patch bump (5.2.3->5.2.4). No public API changes.qs 6.15.2is a patch bump (6.15.1->6.15.2). No public API changes.