Fix unwanted warning when installing using shell script#573
Closed
ronlv4 wants to merge 7 commits intomicrosoft:masterfrom
Closed
Fix unwanted warning when installing using shell script#573ronlv4 wants to merge 7 commits intomicrosoft:masterfrom
ronlv4 wants to merge 7 commits intomicrosoft:masterfrom
Conversation
Author
|
@embetten can you please review? |
Frulfump
reviewed
Jul 14, 2025
Author
|
@Frulfump Hi, anything needed from my side to get this merged? |
Hi @ronlv4 I'm not a maintainer of this project so I couldn't tell you, embetten or @johnterickson @JohnSchmeichel @satbai might be able to help you out here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test and the log are inconsistent in logic, tests if the variable is empty and then log that it is set.
fixed to log only if the variable is not empty.