-
Notifications
You must be signed in to change notification settings - Fork 105
[docs] Update documentation for features from 2026-04-15 #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -161,6 +161,21 @@ apm marketplace update acme-plugins | |||||||
| apm marketplace update | ||||||||
| ``` | ||||||||
|
|
||||||||
| ## Private marketplace repositories | ||||||||
|
|
||||||||
| Private marketplace repositories work without extra configuration. APM uses the same credential resolution as `apm install`: `GITHUB_APM_PAT`, per-org `GITHUB_APM_PAT_{ORG}` env vars, and git credential helpers are all tried automatically before falling back to unauthenticated access. | ||||||||
|
|
||||||||
| ```bash | ||||||||
| export GITHUB_APM_PAT=github_pat_your_token | ||||||||
|
||||||||
| export GITHUB_APM_PAT=github_pat_your_token | |
| export GITHUB_APM_PAT="<your_token>" | |
| # Do not commit or share this value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence claims credentials are tried “before falling back to unauthenticated access,” which can be read as always attempting an unauthenticated request eventually. Since the PR description emphasizes the fix is to avoid an unauthenticated first probe (to prevent 404 confusion), consider rewording to clarify the order for private repos (e.g., credentials are applied on the initial probe/request). This makes the doc consistent with the behavior change being documented.