Skip to content

fix: remove hardcoded haiku model from validation recipe quick-approval steps #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bkrabach wants to merge 1 commit into from
Closed

fix: remove hardcoded haiku model from validation recipe quick-approval steps #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions recipes/validate-agents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# validate-agents.yaml
# Agent Definition Validator Recipe v1.2.3
# Agent Definition Validator Recipe v1.2.5
# Validates agent definitions in a bundle repository for quality, tool access, and structural requirements
#
# CHANGELOG:
# v1.2.5 - Removed hardcoded provider/model from quick-approval step
# - "claude-haiku" is not a valid model ID and breaks execution
# - Quick-approval now uses session default model for portability
#
# v1.2.3 - Fixed multiline string interpolation bug
# - Remove frontmatter and meta fields from structural_results before JSON output
# - These fields contain multiline descriptions that break JSON parsing in downstream steps
Expand Down Expand Up @@ -64,7 +68,7 @@ description: |

This recipe helps maintain agent quality across the Amplifier ecosystem by codifying
the audit criteria discovered in manual reviews.
version: "1.2.4"
version: "1.2.5"
author: "Amplifier Foundation Team"
tags: ["agents", "validation", "quality", "audit", "tools", "descriptions"]

Expand Down Expand Up @@ -793,14 +797,13 @@ steps:
# ============================================================================
# PHASE 3: Quick Approval (When All Agents Pass)
# Fast-track path for bundles that meet all quality thresholds
# Model: haiku - simple summary, no complex reasoning needed
# Simple summary task - uses session default model (no provider/model pinning
# for portability across provider configurations)
# ============================================================================

- id: "quick-approval"
agent: "foundation:zen-architect"
mode: "REVIEW"
provider: "anthropic"
model: "claude-haiku"
condition: "{{quality_classification.requires_llm_analysis}} == false"
depends_on: ["set-default-approval-summary"]
prompt: |
Expand Down
2 changes: 0 additions & 2 deletions recipes/validate-bundle-repo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,8 +2386,6 @@ steps:
- id: "quick-approval"
agent: "foundation:zen-architect"
mode: "REVIEW"
provider: "anthropic"
model: "claude-haiku"
condition: "{{quality_classification.requires_llm_analysis}} == false"
depends_on: ["set-default-approval-summary"]
prompt: |
Expand Down