Fix pyright errors from weave ≥0.52.27 interface changes#497
Fix pyright errors from weave ≥0.52.27 interface changes#497
Conversation
Co-authored-by: ultmaster <8463288+ultmaster@users.noreply.github.com>
…nd add missing abstract method stubs Co-authored-by: ultmaster <8463288+ultmaster@users.noreply.github.com>
pyproject.toml
Outdated
|
|
||
| weave = [ | ||
| "weave>=0.52.22", | ||
| "weave>=0.52.29", |
There was a problem hiding this comment.
@copilot No need to bump weave required version. to test, you need to use uv lock --upgrade to test latest version.
There was a problem hiding this comment.
Reverted the weave version bump in f487e48. pyproject.toml and uv.lock are now unchanged. Added a TYPE_CHECKING guard for backward compat with the OTelExportReq/OTelExportRes rename so the code works at runtime with weave>=0.52.22.
|
@copilot No need to bump weave required version. to test, you need to use uv lock --upgrade to test latest version. |
Co-authored-by: ultmaster <8463288+ultmaster@users.noreply.github.com>
Reverted the weave version bump in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Weave renamed
OtelExportReq/OtelExportRes→OTelExportReq/OTelExportResin v0.52.27 and added new abstract methods toTraceServerInterface/ObjectInterfacein v0.52.29, causing 10 pyright errors.otel_exportsignature and body to useOTelExportReq/OTelExportResTYPE_CHECKINGguarded shim that aliases old names to new names at runtime for weave < 0.52.27, keepingweave>=0.52.22unchanged inpyproject.tomlannotation_queue_delete,annotation_queue_update(raiseNotImplementedError) andeval_results_query(returns empty results) toInMemoryWeaveTraceServerOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.