Fix Kotlin reducer dropping session/mcpServerStateChanged#202
Open
joshmouch wants to merge 1 commit into
Open
Conversation
The Kotlin `sessionReducer` had no arm for the `session/mcpServerStateChanged` action, so the action was decoded off the wire and then silently ignored — an MCP server customization's `state` and `channel` never updated, diverging from the TypeScript reference reducer and the Go/Rust/Swift ports. Add the missing reducer arm: a full replacement of the matched MCP server customization's `state` and `channel`, located by id. A top-level `McpServer` entry is matched first (hosts may surface MCP servers directly at the top level); otherwise the search descends into container children. The action is a no-op when no customization carries the id, or when the matched id belongs to a non-MCP customization type. Add four shared reducer fixtures (159-162) that the cross-language fixture-driven reducer suite picks up automatically, covering the top-level upsert, the container-child upsert, the unknown-id no-op, and the non-MCP-id no-op.
joshmouch
force-pushed
the
pr/fix-kotlin-mcpserver
branch
from
c9df98e to
5a3bfda
Compare
connor4312
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kotlin
sessionReducerhad no arm for thesession/mcpServerStateChangedaction, so the action was decoded off the wire and then silently ignored — an MCP server customization'sstateandchannelnever updated, diverging from the TypeScript reference reducer and the Go/Rust/Swift ports.Fix
Adds the missing reducer arm: a full replacement of the matched MCP server customization's
stateandchannel, located by id. A top-levelMcpServerentry is matched first (hosts may surface MCP servers directly at the top level); otherwise the search descends into container children. The action is a no-op when no customization carries the id, or when the matched id belongs to a non-MCP customization type.Tests
Adds four shared reducer fixtures (159–162) that the cross-language fixture-driven reducer suite picks up automatically — covering the top-level upsert, the container-child upsert, the unknown-id no-op, and the non-MCP-id no-op.
./gradlew testis green.