Fix DeathStarBench venv install to be distro-agnostic#736
Merged
Conversation
The PERF-NETWORK-DEATHSTARBENCH profile installed python3.12-venv, which only exists on Ubuntu 24.04 (Python 3.12) and fails on Ubuntu 22.04 (Python 3.10) and other distros. Use the generic python3-venv meta-package, which resolves to the venv module for each distro's default Python 3. This matches the package the DeathStarBenchExecutor already installs at runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The python3-venv package is now installed by the LinuxPackageInstallation dependency in the PERF-NETWORK-DEATHSTARBENCH profile, so the executor's runtime 'apt install python3-venv -y' is redundant. Removed it and updated the affected unit tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PERF-NETWORK-DEATHSTARBENCHprofile installedpython3.12-venvviaLinuxPackageInstallation. That package only exists on Ubuntu 24.04 (which ships Python 3.12). On Ubuntu 22.04 (Python 3.10) and other distros the package does not exist, so apt fails and the workload can't run.Fix
Use the generic
python3-venvmeta-package, which always resolves to the venv module for each distro's default Python 3 (3.8 / 3.10 / 3.12). This makes the dependency distro-agnostic and matches the package theDeathStarBenchExecutoralready installs at runtime (apt install python3-venv -y).Testing
python3.12-venvin the source tree.