fix: allow enum member references with non-identifier names as computed property names#63304
Closed
cyphercodes wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: allow enum member references with non-identifier names as computed property names#63304cyphercodes wants to merge 1 commit intomicrosoft:mainfrom
cyphercodes wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ed property names in type literals Fixes microsoft#25083 Previously, using an enum member with a non-identifier name (like '3x14') as a computed property name in a type literal would incorrectly produce an error: 'A computed property name in a type literal must refer to an expression whose type is a literal type or a unique symbol type.' The fix updates checkGrammarForInvalidDynamicName to also allow element access expressions where: 1. The argument expression is a string or number literal 2. The expression being accessed is an entity name expression (like Type in Type['3x14']) This enables patterns like: enum Type { '3x14' = '3x14' } type TypeMap = { [Type['3x14']]: any } // Now works!
Member
|
Sorry, but we are not accepting PRs of this kind at this time. https://github.com/microsoft/TypeScript#:~:text=NOTE%3A%20Code%20changes%20in%20this%20repo%20are%20now%20limited%20to%20a%20small%20category%20of%20fixes%3A With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25083
Previously, using an enum member with a non-identifier name (like '3x14') as a computed property name in a type literal would incorrectly produce an error:
'A computed property name in a type literal must refer to an expression whose type is a literal type or a unique symbol type.'
The fix updates checkGrammarForInvalidDynamicName to also allow element access expressions where:
This enables patterns like:
Test case included.