Fix exactOptionalPropertyTypes not enforced through spread-with-terna…#63252
Closed
GokhanKabar wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix exactOptionalPropertyTypes not enforced through spread-with-terna…#63252GokhanKabar wants to merge 1 commit intomicrosoft:mainfrom
GokhanKabar wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ry (#63240) When spreading a conditional expression like `{ ...(cond ? { x: obj.optProp } : {}) }` where `optProp` is an optional property, the exactOptionalPropertyTypes check was silently bypassed. The value of an optional property read (e.g. `obj.optProp`) has the internal type `T | missingType`. In `getAnonymousPartialType`, calling `addOptionality` on that type is a no-op because `missingType` is already the first union member, producing a spread type identical to the target's exact optional property type and suppressing the diagnostic. Fix: when a *required* property's type contains `missingType`, normalize it to `undefinedType` before calling `addOptionality`, so the resulting type is `T | undefined | missingType` — distinguishable from the target — and the check fires.
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #63240
When spreading a conditional expression like
{ ...(cond ? { x: obj.optProp } : {}) }whereoptPropis an optional property, the exactOptionalPropertyTypes check was silently bypassed.The value of an optional property read (e.g.
obj.optProp) has the internal typeT | missingType. IngetAnonymousPartialType, callingaddOptionalityon that type is a no-op becausemissingTypeis already the first union member, producing a spread type identical to the target's exact optional property type and suppressing the diagnostic.Fix: when a required property's type contains
missingType, normalize it toundefinedTypebefore callingaddOptionality, so the resulting type isT | undefined | missingTypedistinguishable from the target and the check fires.