Skip to content

Add IntegerTypedArray type for use with crypto.getRandomValues#61767

Closed
lionel-rowe wants to merge 4 commits intomicrosoft:mainfrom
lionel-rowe:integer-typed-array
Closed

Add IntegerTypedArray type for use with crypto.getRandomValues#61767
lionel-rowe wants to merge 4 commits intomicrosoft:mainfrom
lionel-rowe:integer-typed-array

Conversation

@lionel-rowe
Copy link
Copy Markdown
Contributor

@lionel-rowe lionel-rowe commented May 27, 2025

Fixes #61768

Towards microsoft/TypeScript-DOM-lib-generator#1194

The current DOM types <T extends ArrayBufferView | null> are wrong for crypto.getRandomValues. null is never accepted, and ArrayBufferView is too broad as float arrays also aren't accepted.

However, fixing in TypeScript-DOM-lib-generator requires conditional inclusion of BigInt64Array | BigUint64Array depending on ES2020 availability. I don't think there's a way to fix that within TypeScript-DOM-lib-generator without this upstream change in TypeScript.

Copilot AI review requested due to automatic review settings May 27, 2025 02:39
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog May 27, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 27, 2025
@typescript-bot
Copy link
Copy Markdown
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

1 similar comment
@typescript-bot
Copy link
Copy Markdown
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Mar 24, 2026
@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

IntegerTypedArray type required for use with crypto.getRandomValues

6 participants