Migrate most Index-DB overrides #2292
Open
+27
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Dec 16, 2025
src/build/patches.ts
Outdated
| break; | ||
| } | ||
| // Collect all child type nodes | ||
| const typeNodes = child.children.filter((c) => c.name === "type"); |
Collaborator
There was a problem hiding this comment.
This should look more like handleParam and throw when unknown child node exists
Also it would be nice to split this patch to things that need this logic change and things that do not, because it's too big right now.
Bashamega
changed the title
Contributor
Author
|
I have made it much smaller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only addition in the patches file is to support multiple types and nullable