Fix WebSocket event type imports in agent-server-client #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The isomorphic-ws package doesn't export MessageEvent, CloseEvent, or ErrorEvent types. These types are defined in the WebSocket namespace via @types/ws. Updated to use the namespaced types (WebSocket.MessageEvent, WebSocket.CloseEvent, WebSocket.ErrorEvent) instead of trying to import them directly from isomorphic-ws. This resolves TypeScript compilation errors: - TS2305: Module '"isomorphic-ws"' has no exported member 'MessageEvent' - TS2305: Module '"isomorphic-ws"' has no exported member 'CloseEvent' - TS2305: Module '"isomorphic-ws"' has no exported member 'ErrorEvent' Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
steveluc
temporarily deployed
to
development-fork
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
The
isomorphic-wspackage doesn't actually exportMessageEvent,CloseEvent, orErrorEventtypes. It only re-exports the WebSocket class from thewspackage. The event types are defined in theWebSocketnamespace via@types/ws.Changes:
type MessageEvent,type CloseEvent,type ErrorEventfromisomorphic-wsWebSocket.MessageEventWebSocket.CloseEventWebSocket.ErrorEventFixes these TypeScript compilation errors:
Test plan
pnpm exec tsc -bin agent-server-client packagepnpm build🤖 Generated with Claude Code