Fix o-voxel compilation on Windows (MSVC narrowing conversions)#107
Open
Unk-Cody wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix o-voxel compilation on Windows (MSVC narrowing conversions)#107Unk-Cody wants to merge 1 commit intomicrosoft:mainfrom
Unk-Cody wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description This PR fixes compilation errors encountered when building on Windows using MSVC (Visual Studio 2022).
The Issue MSVC is stricter than GCC/Clang regarding brace initialization. It flagged error C2398 (narrowing conversion) because size_t (unsigned) was being passed into PyTorch tensor lists that expect int64_t (signed).
The Fix
Explicitly cast size_t variables to int64_t in src/io/svo.cpp, src/io/filter_parent.cpp, and src/io/filter_neighbor.cpp.
Minor float literal adjustments in flexible_dual_grid.cpp to prevent truncation warnings.
Verification Verified to compile and run successfully on Windows 11 / CUDA 12.4.
Note: Debugging assistance provided by LLM to identify platform-specific MSVC flags.