Conversation
Removed the invoke of Reporter for scripts Reformat scripts Add files to the project Add hash for these new scripts First set of modifications, this still needs additional testing.
#469 Correcting some typos on the Script
+fixed minor typo issues +removed the GO at the end , it was messing up batch parser and causing a fake failure +Copilot confirmed old and new scripts are functionally same. "only differences are in formatting, capitalization, and comments for readability. There are no changes to the logic, structure, or output of any procedures or functions." +import tests
PiJoCoder
changed the title
Collaborator
|
Tested with new scripts. Also used CoPilot to compare scripts EXEC ReadTrace.spReporter_TimeIntervals;
EXEC ReadTrace.spReporter_TraceFiles;
EXEC ReadTrace.spReporter_MiscInfo;
EXEC ReadTrace.spReporter_ResourceUsageDuringInterval
@StartTimeInterval = NULL, @EndTimeInterval = NULL;Worked just fine |
PiJoCoder
previously approved these changes
Nov 17, 2025
Collaborator
|
@hacitandogan , this is great. Thanks Can you merge master in your branch and resolve the reported conflict? There seems to be a difference in master |
PiJoCoder
approved these changes
Nov 18, 2025
PiJoCoder
deleted the
hacitandogan_20251112_AddReadTracePostScriptsIntoSQLNexus
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+ReadTracePostProcessing.sql inherited from RML Reporter.exe , no need to invoke reporter for those scripts
+Re-format the T-SQL scripts to make them look more professional and prettier
+Introduce these two files in the project as new item