Import running drivers rowset into SQL Nexus and possibly add a report#461
Import running drivers rowset into SQL Nexus and possibly add a report#461
Conversation
PiJoCoder
changed the title
| <Column name="File_Description" type="RowsetImportEngine.VarCharColumn" length="50" /> | ||
| <Column name="Product_Version" type="RowsetImportEngine.VarCharColumn" length="20" /> | ||
| <Column name="File_Version" type="RowsetImportEngine.VarCharColumn" length="25" /> | ||
| <Column name="File_Size_MB" type="RowsetImportEngine.DecimalColumn"/> |
There was a problem hiding this comment.
if we have numbers with commas as decimal separator, we have this issue. If replace commas by points, then it works
|
Based on our previous tests and work on this we were thinking Logscout data is always using "." (dot) as decimal separator and differentiation is coming on SQLNexus side depending on the local settings but looks like that is not entirely true. (And our ConvertFromInvariantString approach is not valid for this ) This data contains "," (comma) as decimal separator , depending on type we used System.ComponentModel.DecimalConverter or System.ComponentModel.DoubleConverter isValid method is returning false hence we are not even trying to convert and returning null. I changed this logic and tests are successful, sending this for your review and tests. |
InvariantCulture always excepts dot , changed the logic to adopt that.
…unning_drivers_rowset_pijocoder_110425
That's great! Thanks @asavioliMSFT , can you please re-test with this build after the changes Haci made |
|
I also tested by purposely changing the decimal separator to comma and imported. Looks good 
|
3 participants
Driver report should look like this:
