Skip to content

[Quick Accent] Remove wpfui#46604

Open
niels9001 wants to merge 2 commits intomainfrom
niels9001/remove-wpfui
Open

[Quick Accent] Remove wpfui#46604
niels9001 wants to merge 2 commits intomainfrom
niels9001/remove-wpfui

Conversation

@niels9001
Copy link
Copy Markdown
Collaborator

@niels9001 niels9001 commented Mar 28, 2026

Summary of the Pull Request

This PR removes the dependency on the WpfUI library and uses plain WPF.

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

  • Replaced ui:FluentWindow with a standard WPF Window and removed the xmlns:ui WpfUI namespace
  • Replaced <Rectangle.Fill><SolidColorBrush /></Rectangle.Fill> with an inline Fill= attribute on the selection indicator rectangle
  • Simplified App.xaml by removing WpfUI theme/controls resource dictionaries and using ThemeMode="System" instead
  • Fixed XAML formatting: converted empty <Application> to a self-closing tag, removed extra blank lines in Window.Resources and inside ControlTemplate

Validation Steps Performed

  • Manually verified the Quick Accent overlay renders correctly with accent character selection and character name display

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@niels9001
Copy link
Copy Markdown
Collaborator Author

@copilot fix xaml formatting

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/c5427b8e-de8e-4c64-ae74-dbfaadf7a69a

Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

@copilot fix xaml formatting

Fixed in fada277:

  • App.xaml: Converted empty <Application> to self-closing tag
  • Selector.xaml: Removed double blank line before </Window.Resources> and extra blank line inside ControlTemplate's <Grid>

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 2kmvsblobprodcus39.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet tool restore --disable-parallel --no-cache (dns block)
    • Triggering command: /usr/bin/dotnet dotnet tool restore grep -l ^&lt;Window xaml (dns block)
  • yttvsblobprodcus357.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet tool install --global xamlstyler.console --version 3.2501.8 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants