Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a WinUI layout bug affecting the CmdPal settings page where content becomes offset/cropped when a MaxWidth panel is hosted inside a ScrollViewer, improving resize behavior in Settings.
Changes:
- Wrapes the CmdPal page content in an additional panel inside the
ScrollViewerto avoid the WinUI offset issue. - Switches the page’s max width from a hard-coded value to the shared
PageMaxWidthresource.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jiripolasek
requested changes
Mar 30, 2026
Collaborator
jiripolasek
left a comment
jiripolasek
left a comment
There was a problem hiding this comment.
Pulled, tested, LGTM
jiripolasek
requested changes
Mar 30, 2026
Co-authored-by: Jiří Polášek <me@jiripolasek.com>
jiripolasek
approved these changes
Apr 1, 2026
LegendaryBlair
added
the
Product-Command Palette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is a weird bug in WinUI where a child panel gets a weird offset when wrapped in a
ScrollViewerand if it has aMaxWidth. The solution is to wrap it with another panel 🤷Top: with fix
Bottom: 0.98.1
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed