Extract PowerDisplay.Models to decouple Settings.UI from PowerDisplay…#46489
Draft
Extract PowerDisplay.Models to decouple Settings.UI from PowerDisplay…#46489
Conversation
….Lib - Create PowerDisplay.Models project with shared model types (ColorPresetItem, CustomVcpValueMapping, PowerDisplayProfile, PowerDisplayProfiles, ProfileMonitorSetting) and ProfileHelper/ProfileSerializationContext - Remove Settings.UI and Settings.UI.Library dependency on PowerDisplay.Lib - Clean up VcpNames: remove LocalizedCodeNameProvider, GetValueMappings, GetFormattedValueName with custom mapping overload (keep 4 methods) - Refactor ProfileService: delegate Load/Save to ProfileHelper, remove unused methods (ProfilesFileExists, GetProfilesFilePath), simplify IProfileService interface - Remove legacy CustomProfileName constant and cleanup code - Add CustomVcpValueMappingExtensions in Lib for rich display properties - Create MonitorStateSerializationContext for Lib-local state types Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….Lib
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed