CmdPal: Rename id→appUserModelId in LaunchProfileCommand to remove ambiguity#46481
Merged
michaeljolley merged 2 commits intoniels9001/cmdpal-terminal-dock-pinningfrom Mar 24, 2026
Merged
Conversation
13 tasks
Co-authored-by: michaeljolley <1228996+michaeljolley@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/efdcc731-3596-4985-bec3-4681882b207c
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on CmdPal dock pinning and profile icons implementation
CmdPal: Rename Mar 24, 2026
id→appUserModelId in LaunchProfileCommand to remove ambiguity
michaeljolley
approved these changes
Mar 24, 2026
9250c82
into
niels9001/cmdpal-terminal-dock-pinning
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
LaunchProfileCommandhad a constructor parameteridand backing field_idthat held the TerminalAppUserModelIdused for COM activation, which was ambiguous given the base classIdproperty (set to a generated command identifier viaMakeId). Renames the parameter and field throughout toappUserModelId/_appUserModelId.PR Checklist
Detailed Description of the Pull Request / Additional comments
Addresses review feedback on #46372. Changes in
LaunchProfileCommand.cs:_idfield →_appUserModelIdid→appUserModelIdLaunch(string id, ...)→Launch(string appUserModelId, ...)Before, both the activation ID and the command identity used
id-derived names, making it easy to accidentally pass the wrong value. TheMakeIdstatic method already usedappUserModelIdas its parameter; this aligns the rest of the class with that convention.Validation Steps Performed
ProfilesListPage.cs) already passesprofile.Terminal.AppUserModelId— no functional change.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.