CmdPal: Add slideshow background mode and rotation settings by Error0229 · Pull Request #46452 · microsoft/PowerToys

Error0229 · 2026-03-24T00:52:14Z

Summary of the Pull Request

Add a dedicated Slideshow background mode in CmdPal appearance settings
Add slideshow folder path, change interval (on activation / 1 / 10 / 30 / 60 min), and shuffle settings
Add slideshow rotation engine in ThemeService — rotates on hide so next activation shows new image
Shuffle uses Fisher-Yates algorithm to guarantee every image is shown before any repeats
Add BackgroundImagePathResolver utility with 13 unit tests
Fix a settings crash by guarding against empty preview image paths

PR Checklist

Closes: CmdPal: Support background image rotation from a folder #45879
Communication: This is a community contribution for my own feature request (CmdPal: Support background image rotation from a folder #45879). Happy to adjust the approach based on team feedback.
Tests: Added/updated and all pass
Localization: All end-user-facing strings can be localized
Dev docs: N/A — no new module or public API surface
New binaries: N/A — no new binaries added
Documentation updated: N/A — internal feature addition, no external docs change needed

Detailed Description of the Pull Request / Additional comments

New mode: Slideshow

ColorizationMode.Slideshow is added alongside the existing Image mode. Both modes share tint/opacity/blur/fit controls, but have separate path controls — single-image uses a file picker (BackgroundImagePath), slideshow uses a folder picker (BackgroundImageSlideshowFolderPath).

Rotation engine

ThemeService maintains internal state to track the current slideshow image. Rotation triggers on: folder changed, current file deleted, or activation after the configured interval elapsed. Supports both shuffle and sequential (alphabetical wrap-around) ordering.

Shuffle algorithm

Uses Fisher-Yates to pre-shuffle the full index array, then walks through it with a cursor. When the deck is exhausted, reshuffles — with the last-shown image swapped away from position 0 to avoid repeats at deck boundaries. This guarantees every image is shown exactly once before any image repeats.

Rotation timing

MainWindow.HideWindow() calls RefreshThemeForActivation() before hiding, so the image swaps while invisible — no flicker on next activation.

Settings

New JSON keys (additive, no migration needed):

BackgroundImageSlideshowFolderPath (string)
BackgroundImageChangeIntervalMinutes (int, default 0 = on activation only)
BackgroundImageShuffle (bool, default true)

Validation Steps Performed

Built src/modules/cmdpal/Microsoft.CmdPal.UI with tools/build/build.cmd (Debug/x64) — 0 errors
Built and ran BackgroundImagePathResolverTests (13/13 passed)
Manually validated CmdPal settings flow for Image vs Slideshow modes
Validated on-hide rotation behavior
Verified shuffle covers all images before repeating

…t#45879) Add a dedicated Slideshow background mode in CmdPal appearance settings with folder-based image rotation, configurable interval, and shuffle. - Add ColorizationMode.Slideshow enum value - Add slideshow folder path, change interval, and shuffle settings - Add slideshow rotation engine in ThemeService (sequential/shuffle, interval-based, rotate-on-hide so next activation shows new image) - Add BackgroundImagePathResolver utility with unit tests (13 tests) - Add folder picker and slideshow controls to AppearancePage - Fix settings crash on empty preview image paths - Add localized strings for all new UI elements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Single-button StackPanel wrappers around the image picker and folder picker buttons serve no purpose. Use the Button directly as the SettingsCard content. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…eImageUri Move the relative-path-to-absolute-URI logic out of the view model ternary chains into a dedicated helper. Both AppearanceSettingsViewModel and DockAppearanceSettingsViewModel now read as a simple null-check chain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Error0229 · 2026-03-24T00:53:43Z

@microsoft-github-policy-service agree

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/AppearanceSettingsViewModel.cs

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Services/IThemeService.cs

src/modules/cmdpal/Microsoft.CmdPal.UI/MainWindow.xaml.cs

src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

michaeljolley · 2026-03-24T02:06:12Z

/azp run

azure-pipelines · 2026-03-24T02:06:22Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Adds a new Slideshow background mode to CmdPal’s appearance settings, including folder selection and rotation behavior, so users can rotate background images from a directory instead of a single file.

Changes:

Introduces ColorizationMode.Slideshow plus new persisted settings for slideshow folder, change interval, and shuffle.
Updates settings UI to support slideshow selection (folder picker + interval/shuffle controls).
Adds BackgroundImagePathResolver utility (with unit tests) and wires it into theme/image preview paths.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ColorizationMode.cs	Adds `Slideshow` mode to the colorization enum.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/SettingsModel.cs	Persists slideshow folder, interval minutes, and shuffle flag.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Services/IThemeService.cs	Adds `RefreshThemeForActivation()` hook for summon-time refresh behavior.
src/modules/cmdpal/Microsoft.CmdPal.UI/Services/ThemeService.cs	Implements slideshow rotation/selection logic and integrates slideshow into theme snapshot generation.
src/modules/cmdpal/Microsoft.CmdPal.UI/MainWindow.xaml.cs	Triggers slideshow refresh before hiding to avoid visible swaps on next activation.
src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/AppearancePage.xaml	Adds Slideshow option and slideshow-specific settings cards/controls.
src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/AppearancePage.xaml.cs	Implements folder picker and forces mode switch when picking file/folder.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/AppearanceSettingsViewModel.cs	Adds slideshow settings bindings and preview image resolution logic.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/DockAppearanceSettingsViewModel.cs	Uses resolver-based URI creation for safer image preview resolution.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/MainWindowViewModel.cs	Applies theme snapshots on UI thread without always dispatching.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/BackgroundImagePathResolver.cs	New helper to resolve folder-vs-file paths, supported images, and safe image URIs.
src/modules/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/BackgroundImagePathResolverTests.cs	Adds unit tests covering resolver behaviors (folder/file/URI cases).
src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw	Adds localized strings for slideshow UI and interval/shuffle labels.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx	Adds localized string used by folder picker commit button.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs	Regenerates strongly-typed accessor for the new resx string.
.github/actions/spell-check/expect.txt	Adds “slideshow” to spelling allow-list and removes an unused entry.

Files not reviewed (1)

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs: Language not supported

src/modules/cmdpal/Microsoft.CmdPal.UI/Services/ThemeService.cs

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/AppearanceSettingsViewModel.cs

…trings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs: Language not supported

Copilot · 2026-03-28T00:01:48Z

...es/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/BackgroundImagePathResolverTests.cs

+    public void TryGetLocalFolderPath_WithNull_ReturnsFalse()
+    {
+        var ok = BackgroundImagePathResolver.TryGetLocalFolderPath(null, out var resolved);
+
+        Assert.IsFalse(ok);


Add a unit test that passes an invalid/malformed path (illegal characters or malformed URI) into TryGetLocalFolderPath and asserts it returns false without throwing. This matters because the resolver is invoked from UI-bound properties and theme reload code paths.

Copilot · 2026-03-28T00:01:48Z

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/BackgroundImagePathResolver.cs

+        var localCandidate = Path.GetFullPath(candidate);
+        if (!Directory.Exists(localCandidate))
+        {
+            return false;
+        }
+
+        folderPath = localCandidate;
+        return true;


TryGetLocalFolderPath uses Path.GetFullPath(candidate) without guarding for ArgumentException / NotSupportedException (e.g., settings.json contains an invalid path). That will throw and can crash theme reload/settings UI. Wrap GetFullPath in a try/catch and return false on invalid paths.

Suggested change

var localCandidate = Path.GetFullPath(candidate);

if (!Directory.Exists(localCandidate))

{

return false;

}

folderPath = localCandidate;

return true;

try

{

var localCandidate = Path.GetFullPath(candidate);

if (!Directory.Exists(localCandidate))

{

return false;

}

folderPath = localCandidate;

return true;

}

catch (ArgumentException)

{

return false;

}

catch (NotSupportedException)

{

return false;

}

Copilot · 2026-03-28T00:01:48Z

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/BackgroundImagePathResolver.cs

+    public static readonly HashSet<string> SupportedImageExtensions = new(StringComparer.OrdinalIgnoreCase)
+    {
+        ".png",


SupportedImageExtensions is exposed as a public mutable HashSet<string>, so external callers can add/remove extensions at runtime and break filtering. Consider exposing an immutable view (e.g., IReadOnlyCollection<string> / string[]) and keeping the HashSet private for membership checks.

Copilot · 2026-03-28T00:01:49Z

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Services/IThemeService.cs

+    /// Requests an immediate refresh for summon-time visuals.
+    /// </summary>
+    /// <remarks>
+    /// Used for activation-driven updates such as background slideshow rotation.


RefreshThemeForActivation() is a new public interface member but doesn’t document thread-affinity. Since the implementation calls Reload() (which touches XAML/BitmapImage), please document that it must be invoked on the UI thread (or enforce via an assert/dispatcher marshal) to prevent future off-thread callers from causing crashes.

Suggested change

/// Used for activation-driven updates such as background slideshow rotation.

/// Used for activation-driven updates such as background slideshow rotation.

/// This method is UI-thread-affine and must be invoked on the UI thread.

/// Callers are responsible for marshalling to the UI thread (for example, via a dispatcher)

/// before invoking this method.

catol-abacus and others added 3 commits March 23, 2026 17:13

github-advanced-security bot found potential problems Mar 24, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

chore: add 'slideshow' to spell-check expect list

1d6734e

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Error0229 force-pushed the feature/cmdpal-background-slideshow-45879 branch from f715528 to 1d6734e Compare March 24, 2026 01:18

michaeljolley added the Product-Command Palette Refers to the Command Palette utility label Mar 24, 2026

michaeljolley requested a review from Copilot March 24, 2026 18:40

Copilot started reviewing on behalf of michaeljolley March 24, 2026 18:41 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

src/modules/cmdpal/Microsoft.CmdPal.UI/Services/ThemeService.cs Show resolved Hide resolved

src/modules/cmdpal/Microsoft.CmdPal.UI/Services/ThemeService.cs Show resolved Hide resolved

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/AppearanceSettingsViewModel.cs Show resolved Hide resolved

Merge upstream/main: resolve Resources.resw conflict with PinToDock s…

6982536

…trings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

michaeljolley added the Merge conflict 🙀 label Mar 27, 2026

michaeljolley requested a review from Copilot March 27, 2026 23:52

Copilot started reviewing on behalf of michaeljolley March 27, 2026 23:56 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

-    /// Used for activation-driven updates such as background slideshow rotation.
+    /// Used for activation-driven updates such as background slideshow rotation.
+    /// This method is UI-thread-affine and must be invoked on the UI thread.
+    /// Callers are responsible for marshalling to the UI thread (for example, via a dispatcher)
+    /// before invoking this method.

Conversation

Error0229 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

New mode: Slideshow

Rotation engine

Shuffle algorithm

Rotation timing

Settings

Validation Steps Performed

Uh oh!

Error0229 commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

michaeljolley commented Mar 24, 2026

Uh oh!

azure-pipelines bot commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Error0229 commented Mar 24, 2026 •

edited

Loading