Publicly accessible PrettyPrint in CheckResult #2582#3030
Open
modery wants to merge 1 commit intomicrosoft:mainfrom
Open
Publicly accessible PrettyPrint in CheckResult #2582#3030modery wants to merge 1 commit intomicrosoft:mainfrom
modery wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no publicly accessible PrettyPrint function. The TexlParser.Format function does the right job, but it is only accessible internally. By providing a publicly accessible function, other tools can make use of it to format PowerFx code in a nicer way.
This contribution adds a publicly accessible PrettyPrint function, CheckResult.ApplyFormat(), as requested in #2582
Fix
File: src/libraries/Microsoft.PowerFx.Core/Public/CheckResult.cs
CheckResult.cs has been updated with a new function called ApplyFormat(), which returns the pretty-printed form of the expression. This way, we can use an Engine() object with CheckResult, set the text, and apply formatting:
Tests
File: src/tests/Microsoft.PowerFx.Core.Tests.Shared/FormatterTests.cs
Test cases have been added similar to the existing TestPrettyPrint test case