XS✔ ◾ Fix Small Bugs and Remove Test Mock Artifact by muiriswoulfe · Pull Request #783 · microsoft/PR-Metrics

muiriswoulfe · 2026-04-10T10:06:57Z

Summary

azureReposInvoker.ts / gitHubReposInvoker.ts: Reject blank and whitespace-only access tokens.
baseReposInvoker.ts: Separate HTTP 404 from 401/403 with distinct localised error message.
codeMetrics.ts: Remove endingToRemove block (test mock artefact) and fix test.
consoleWrapper.ts: Sanitise newlines to prevent log injection.
gitHubReposInvoker.ts: Make Link header regex more permissive for pagination.
httpWrapper.ts: Add HTTP error check and abort timeout (30 s).
inputs.ts: Trim lines and filter empty entries after splitting.
logger.ts: try/catch JSON.stringify; redact sensitive properties; sanitise newlines.
octokitGitDiffParser.ts: Add binary file guard for RenamedFile; replace for/push with .map().
pullRequest.ts: Fix isPullRequest to check GITHUB_BASE_REF is defined.
pullRequestMetrics.ts: Guard error cast with instanceof Error; replay logger in both branches.
tokenManager.ts: Move _previouslyInvoked after successful token acquisition.

muiriswoulfe · 2026-04-10T10:10:54Z

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

	Lines
Product Code	111
Test Code	211
Subtotal	322
Ignored Code	6
Total	328

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

muiriswoulfe · 2026-04-10T10:13:29Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

This parameter has no effect on GitHub because GitHub issue/review comments have no Active/Closed thread status. It only applies to Azure DevOps, where it is already defined in task.json.

muiriswoulfe · 2026-04-10T10:17:38Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

muiriswoulfe · 2026-04-10T10:17:55Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot

Pull request overview

This PR improves robustness and diagnostics across the PR Metrics task (GitHub Action + Azure DevOps task) by tightening error handling, input parsing, and diff parsing, while also cleaning up a test-only artifact in metrics parsing.

Changes:

Add safer operational guards (HTTP timeouts/status checks, binary diff handling, non-Error throws handling).
Improve security/diagnostics (error-property redaction, clearer 404 messaging, stricter access-token presence checks).
Remove a test mock artifact from CodeMetrics parsing and update/extend unit tests accordingly.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/task/src/wrappers/httpWrapper.ts	Adds request timeout + `response.ok` validation for diff downloads.
src/task/src/utilities/constants.ts	Introduces a shared HTTP timeout constant.
src/task/src/utilities/logger.ts	Adds sensitive-field redaction + safe serialization for error logging.
src/task/src/repos/tokenManager.ts	Allows retry by only marking invocation after successful token acquisition.
src/task/src/repos/gitHubReposInvoker.ts	Rejects empty tokens; relaxes Link header parsing for pagination.
src/task/src/repos/azureReposInvoker.ts	Rejects empty tokens.
src/task/src/repos/baseReposInvoker.ts	Splits 404 handling from 401/403 with a distinct message.
src/task/src/pullRequests/pullRequest.ts	Fixes GitHub PR detection when `GITHUB_BASE_REF` is undefined.
src/task/src/pullRequestMetrics.ts	Handles non-`Error` thrown values when failing the task.
src/task/src/metrics/inputs.ts	Trims per-line values for patterns/extensions inputs.
src/task/src/metrics/codeMetrics.ts	Removes mock-only output stripping and updates error message text accordingly.
src/task/src/git/octokitGitDiffParser.ts	Skips renamed binary files; simplifies diff splitting via `.map()`.
action.yml	Adds `always-close-comment` input definition for the GitHub Action.
src/task/tests/utilities/logger.spec.ts	Adds tests for redaction and non-serializable error properties.
src/task/tests/repos/gitHubReposInvoker.spec.ts	Updates assertions for new 404 error messaging behavior.
src/task/tests/repos/azureReposInvoker.spec.ts	Updates assertions for new 404 error messaging behavior.
src/task/tests/pullRequestMetrics.spec.ts	Adds coverage for non-`Error` thrown values.
src/task/tests/metrics/codeMetrics.spec.ts	Updates test data to match removal of mock artifact stripping.
src/task/tests/git/octokitGitDiffParser.spec.ts	Adds coverage for renamed binary file handling.

src/task/src/repos/gitHubReposInvoker.ts

src/task/src/repos/azureReposInvoker.ts

src/task/src/repos/baseReposInvoker.ts

src/task/src/pullRequestMetrics.ts

muiriswoulfe · 2026-04-10T10:22:52Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

muiriswoulfe · 2026-04-10T14:04:27Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.

src/task/src/repos/baseReposInvoker.ts

src/task/src/utilities/logger.ts

src/task/src/wrappers/consoleWrapper.ts

dist/index.mjs

dist/resources.resjson

muiriswoulfe · 2026-04-10T15:39:55Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

dist/index.mjs

dist/resources.resjson

dist/index.mjs

dist/resources.resjson

muiriswoulfe · 2026-04-10T16:28:02Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

muiriswoulfe · 2026-04-10T16:29:00Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 1 comment.

src/task/src/utilities/logger.ts

Use a JSON replacer to redact nested sensitive properties (e.g. request.headers.authorization) during serialization, not just top-level property names.

dist/resources.resjson

muiriswoulfe · 2026-04-10T16:59:09Z

Super-linter summary

Language	Validation result
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
EDITORCONFIG	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
JSON_PRETTIER	Pass ✅
MARKDOWN	Pass ✅
MARKDOWN_PRETTIER	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
TYPESCRIPT_PRETTIER	Pass ✅
XML	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Fix small bugs and remove test mock artifact

1d8ae24

muiriswoulfe requested review from a team and Copilot April 10, 2026 10:06

muiriswoulfe temporarily deployed to production April 10, 2026 10:07 — with GitHub Actions Inactive

muiriswoulfe changed the title ~~Fix Small Bugs and Remove Test Mock Artifact~~ XS✔ ◾ Fix Small Bugs and Remove Test Mock Artifact Apr 10, 2026

Copilot started reviewing on behalf of muiriswoulfe April 10, 2026 10:11 View session

chore: fix linting, update dist folder

6063ce9

muiriswoulfe temporarily deployed to production April 10, 2026 10:11 — with GitHub Actions Inactive

muiriswoulfe had a problem deploying to production April 10, 2026 10:11 — with GitHub Actions Failure

muiriswoulfe temporarily deployed to production April 10, 2026 10:11 — with GitHub Actions Inactive

chore: fix linting

8af8584

muiriswoulfe temporarily deployed to production April 10, 2026 10:13 — with GitHub Actions Inactive

Remove always-close-comment from action.yml

56d4b4f

This parameter has no effect on GitHub because GitHub issue/review comments have no Active/Closed thread status. It only applies to Azure DevOps, where it is already defined in task.json.

muiriswoulfe temporarily deployed to production April 10, 2026 10:17 — with GitHub Actions Inactive

Copilot AI reviewed Apr 10, 2026

View reviewed changes

src/task/src/repos/gitHubReposInvoker.ts Outdated Show resolved Hide resolved

src/task/src/repos/azureReposInvoker.ts Outdated Show resolved Hide resolved

src/task/src/repos/baseReposInvoker.ts Show resolved Hide resolved

src/task/src/pullRequestMetrics.ts Show resolved Hide resolved

muiriswoulfe temporarily deployed to production April 10, 2026 14:01 — with GitHub Actions Inactive

Copilot started reviewing on behalf of muiriswoulfe April 10, 2026 14:03 View session

microsoft deleted a comment from muiriswoulfe Apr 10, 2026

Copilot AI reviewed Apr 10, 2026

View reviewed changes

src/task/src/repos/baseReposInvoker.ts Outdated Show resolved Hide resolved

src/task/src/utilities/logger.ts Show resolved Hide resolved

src/task/src/wrappers/consoleWrapper.ts Outdated Show resolved Hide resolved

Update JSDoc for sanitization and notFoundErrorMessage parameter

050208b

muiriswoulfe temporarily deployed to production April 10, 2026 15:37 — with GitHub Actions Inactive

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/index.mjs Show resolved Hide resolved

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/resources.resjson Show resolved Hide resolved

Updating logger

6ee9bef

Copilot AI review requested due to automatic review settings April 10, 2026 16:25

muiriswoulfe temporarily deployed to production April 10, 2026 16:25 — with GitHub Actions Inactive

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/index.mjs Show resolved Hide resolved

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/resources.resjson Show resolved Hide resolved

chore: fix linting, update dist folder

d416345

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/index.mjs Show resolved Hide resolved

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/resources.resjson Show resolved Hide resolved

Copilot AI reviewed Apr 10, 2026

View reviewed changes

src/task/src/utilities/logger.ts Show resolved Hide resolved

Redact sensitive keys recursively in logErrorObject

3db9fa7

Use a JSON replacer to redact nested sensitive properties (e.g. request.headers.authorization) during serialization, not just top-level property names.

muiriswoulfe commented Apr 10, 2026

View reviewed changes

dist/resources.resjson Show resolved Hide resolved

Conversation

muiriswoulfe commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

muiriswoulfe commented Apr 10, 2026 • edited by omex-github-bot-external Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Metrics

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

muiriswoulfe commented Apr 10, 2026

Super-linter summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

muiriswoulfe commented Apr 10, 2026 •

edited

Loading

muiriswoulfe commented Apr 10, 2026 •

edited by omex-github-bot-external

Loading