Update model package cli to match latest schema#2445
Open
xiaoyu-work wants to merge 2 commits intomainfrom
Open
Update model package cli to match latest schema#2445xiaoyu-work wants to merge 2 commits intomainfrom
xiaoyu-work wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates olive generate-model-package to emit an ORT model-package “proposal-shaped” directory layout and schema, and expands test coverage to validate the new manifest/metadata/variant format and external-data handling.
Changes:
- Reworked CLI packaging to generate
manifest.jsonwithschema_version/components, and per-componentmetadata.json+ per-variantvariant.jsonunder top-level component directories (nomodels/wrapper). - Added a
write_model_packagewriter with validation,configs/copying, and optional cross-variant external-data dedup intoshared_weights/. - Greatly expanded CLI+writer tests (single-source allowed, composite inference precedence, compatibility parsing, dedup behavior, and safety checks).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
olive/cli/model_package.py |
Refactors the CLI to build VariantSpecs and writes a proposal-shaped model package (manifest/metadata/variant.json), including external-data discovery and optional dedup. |
test/cli/test_model_package.py |
Replaces/extends tests to validate the new schema/layout, helper behavior, composite inference precedence, and external-data dedup + safety. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update model package cli to match latest schema
Checklist before requesting a review
lintrunner -a(Optional) Issue link