COPY OF 2307 #2308
Closed
COPY OF 2307 #2308
+356
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With newer NNCF, it is necessary to specify group size fallback in advanced compression parameters, which is reflected in a few unit tests that fail due to InvalidGroupSizeError. Also updated the Intel® NNCF Compression pass in Olive OpenVINO passes to accurately handle advanced parameters in both enum and string forms - [ ] Add unit tests for this change. - [x] Make sure all tests can pass. - [ ] Update documents if necessary. - [x] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With newer NNCF, it is necessary to specify group size fallback in advanced compression parameters, which is reflected in a few unit tests that fail due to InvalidGroupSizeError.
Also updated the Intel® NNCF Compression pass in Olive OpenVINO passes to accurately handle advanced parameters in both enum and string forms
lintrunner -aDescribe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link