Add 'dotnet new' templates for NoTargets and Traversal#529
Open
MattKotsenas wants to merge 14 commits intomicrosoft:mainfrom
Open
Add 'dotnet new' templates for NoTargets and Traversal#529MattKotsenas wants to merge 14 commits intomicrosoft:mainfrom
MattKotsenas wants to merge 14 commits intomicrosoft:mainfrom
Conversation
f732bcb to
1b20fd1
Compare
Member
Author
|
Friendly ping here. I fully expect this review to take a couple of rounds to get the directory layout the way maintainers want, so any help / guidance is very appreciated. Thanks! |
Contributor
|
@AndyGerlicher has assumed ownership of this repo |
Member
|
Just FYI discussing this internally with the MSBuild team. I want to make sure this aligns with their vision before we make this change. Sorry for the delay! |
Member
Author
|
Hi there! Friendly ping here. Any updates, or concerns / issues I can help address? Thanks! |
115afd1 to
2141411
Compare
2141411 to
3f36499
Compare
Member
Author
|
/cc @baronfel, @rainersigwald, @AndyGerlicher I've rebased this on latest main. Would everyone mind taking a look? I'm open to how best to structure and organize things, so let me know what you all prefer. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #472
Add two new projects:
Microsoft.Build.NoTargets.TemplatesandMicrosoft.Build.Traversal.Templatesthat each publish a NuGet package that can be installed / used viadotnet new.I wasn't quite sure how best to structure the project, so feedback is appreciated. Some things to consider:
.csprojextension. If we should use.proj, or if there's a better extension to use, please let me know.TargetFrameworkVersionin the README from net462 to netstandard2.0, since that's compatible with both .NET Framework and .NET, and still supported (basically) everywhere.