Skip to content

Update msbench script and pipeline#1070

Merged
fanyang-mono merged 11 commits intomainfrom
users/pahallis/run-bench
Mar 3, 2026
Merged

Update msbench script and pipeline#1070
fanyang-mono merged 11 commits intomainfrom
users/pahallis/run-bench

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Feb 27, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 27, 2026 22:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure DevOps benchmark pipeline and its PowerShell runner script to install MSBench CLI at runtime and invoke a Copilot benchmark run.

Changes:

  • Replaced the benchmark runner script with a stricter, parameterized implementation that installs MSBench CLI from an Azure Artifacts feed and pulls a GitHub PAT from Key Vault.
  • Updated the pipeline to run on main pushes and to provision Python 3.11 before executing the script.
  • Removed the prior -BuildId argument wiring from the pipeline.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
pipelines/scripts/Invoke-CopilotBenchmarks.ps1 Adds parameter validation, Key Vault secret retrieval, Python/pip setup, MSBench CLI install, and constructs the msbench-cli run invocation.
pipelines/azure-benchmarks.yml Enables CI trigger on main, adds UsePythonVersion@0 for Python 3.11, and updates script invocation.

Copilot AI review requested due to automatic review settings February 27, 2026 23:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

pipelines/scripts/Invoke-CopilotBenchmarks.ps1:39

  • The example uses -NoWait "false", but NoWait is a [switch] parameter, so providing a positional string argument will fail parsing (or won’t do what the example claims). Update the example to use PowerShell switch syntax (e.g., -NoWait:$false) or change NoWait to a boolean/string parameter if you want to accept explicit true/false values.
    PS> ./Invoke-CopilotBenchmarks.ps1 -Benchmark azure.120 -Model "claude-sonnet-4.5-autodev-test" -NoWait "false"

    Runs benchmark azure.120 with explicit model and waits for completion.

@hallipr hallipr force-pushed the users/pahallis/run-bench branch from 9f8ab84 to 66b358e Compare February 28, 2026 00:47
Copilot AI review requested due to automatic review settings February 28, 2026 00:51
@hallipr hallipr force-pushed the users/pahallis/run-bench branch from 66b358e to fab14ee Compare February 28, 2026 00:51
@hallipr hallipr force-pushed the users/pahallis/run-bench branch from fab14ee to 5cfef1c Compare February 28, 2026 00:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings February 28, 2026 01:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

hallipr and others added 2 commits February 27, 2026 17:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 28, 2026 01:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings March 2, 2026 21:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

hallipr and others added 2 commits March 2, 2026 14:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 3, 2026 02:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

@fanyang-mono fanyang-mono merged commit 3cea605 into main Mar 3, 2026
12 checks passed
@fanyang-mono fanyang-mono deleted the users/pahallis/run-bench branch March 3, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants