Skip to content

test(tree): speed up createTableTree test setup#27501

Merged
brrichards merged 2 commits into
microsoft:mainfrom
brrichards:tableSchema-setup-perf
Jun 6, 2026
Merged

test(tree): speed up createTableTree test setup#27501
brrichards merged 2 commits into
microsoft:mainfrom
brrichards:tableSchema-setup-perf

Conversation

@brrichards
Copy link
Copy Markdown
Contributor

Summary

Optimizes dense-table construction in the tableSchema benchmark test utility. Instead of inserting empty rows and then issuing one setCell op per cell, each row is now built with its cells pre-populated and the whole table is inserted with a single insertRows op.

Tested specifically against tableSchema memory benchmarks which run ~8 minutes faster.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings June 6, 2026 00:14
@brrichards brrichards requested a review from a team as a code owner June 6, 2026 00:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (31 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

Fleet Review — Clean

No issues found across the reviewer fleet for this run.

View run

@brrichards brrichards merged commit 21c6cf4 into microsoft:main Jun 6, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants