test(tree): speed up createTableTree test setup#27501
Merged
Merged
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (31 lines, 1 files), I've queued these reviewers:
How this works
|
Josmithr
approved these changes
Jun 6, 2026
Contributor
Fleet Review — CleanNo issues found across the reviewer fleet for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes dense-table construction in the tableSchema benchmark test utility. Instead of inserting empty rows and then issuing one
setCellop per cell, each row is now built with its cells pre-populated and the whole table is inserted with a singleinsertRowsop.Tested specifically against tableSchema memory benchmarks which run ~8 minutes faster.
Reviewer Guidance
The review process is outlined on this wiki page.