Skip to content

fix(datastore): Log when a DDS fails to load, including dataStore metadata#27500

Open
markfields wants to merge 8 commits into
microsoft:mainfrom
markfields:dds/getchannel-error-logging
Open

fix(datastore): Log when a DDS fails to load, including dataStore metadata#27500
markfields wants to merge 8 commits into
microsoft:mainfrom
markfields:dds/getchannel-error-logging

Conversation

@markfields
Copy link
Copy Markdown
Member

Description

When a DDS fails to load, we need to know what DataStore it was under for diagnostic purposes. But in some cases (e.g. if it's the Summarizer client), the stack that first awaits the getChannel call doesn't afford any insight into which DataStore it was, and we just get the raw error at a higher level choke point (e.g. Summarizer failing and closing), with no helpful context besides what we can glean from the minified stack.

This PR adds a catch-log-throw block around the internal channelP promise so as soon as it rejects, we get a log that includes DataStore metadata (its ID and package path).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (287 lines, 6 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@markfields markfields added the release-blocking Must be addressed before we cut and publish the next release label Jun 6, 2026
@markfields
Copy link
Copy Markdown
Member Author

Tagging as release-blocking, this is blocking the safe rollout of a feature in a 1P partner

@markfields markfields marked this pull request as ready for review June 6, 2026 01:33
Copilot AI review requested due to automatic review settings June 6, 2026 01:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocking Must be addressed before we cut and publish the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants