fix(datastore): Log when a DDS fails to load, including dataStore metadata#27500
Open
markfields wants to merge 8 commits into
Open
fix(datastore): Log when a DDS fails to load, including dataStore metadata#27500markfields wants to merge 8 commits into
markfields wants to merge 8 commits into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (287 lines, 6 files), I've queued these reviewers:
How this works
|
Member
Author
|
Tagging as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a DDS fails to load, we need to know what DataStore it was under for diagnostic purposes. But in some cases (e.g. if it's the Summarizer client), the stack that first awaits the
getChannelcall doesn't afford any insight into which DataStore it was, and we just get the raw error at a higher level choke point (e.g. Summarizer failing and closing), with no helpful context besides what we can glean from the minified stack.This PR adds a catch-log-throw block around the internal
channelPpromise so as soon as it rejects, we get a log that includes DataStore metadata (its ID and package path).