Skip to content

Update build-tools used in build-tools#27485

Open
CraigMacomber wants to merge 1 commit into
microsoft:mainfrom
CraigMacomber:buildToolsTools
Open

Update build-tools used in build-tools#27485
CraigMacomber wants to merge 1 commit into
microsoft:mainfrom
CraigMacomber:buildToolsTools

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

Description

As part of trying to update to pnpm 11 with its more robust trust policy, I noticed we have several existing trust policy violations in existing lock files which will fail with pnpm 11. To simplify this, I'm updating build tools, so that the versions of packages which need exclusions are the same across different workspaces so the esclusions we already have can be copied instead of introducing new ones (which adds risk and complexity).

This updates build tools used by build tools to match the version used in the root, and moves over some of the required trust poicy exclusions required to use build tools.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings June 4, 2026 19:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (1429 lines, 6 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • build-tools/pnpm-lock.yaml: Language not supported

Comment thread build-tools/pnpm-workspace.yaml
Comment on lines 2013 to +2015
'@ungap/structured-clone@1.2.0':
resolution: {integrity: sha512-zuVdFrMJiuCDQUMCzQaD6KL28MjnqqN8XnAqiEq9PNm/hCPTSGfrXCOfwj1ow4LFb/tNymJPwsNbVePc1xFqrQ==}
deprecated: Potential CWE-502 - Update to 1.3.1 or higher
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency is not a direct one, and what depends on it pins a specific version. As this is not a regression in this change, and will be picked up by our scanners, I'm considering it out of scope and can be addressed later.

Copy link
Copy Markdown
Contributor

@ChumpChief ChumpChief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants