Skip to content

fix: make ci-readiness-check.sh compatible with bash 3.2#27465

Open
tylerbutler wants to merge 1 commit into
microsoft:mainfrom
tylerbutler:fix/ci-readiness-bash32-compat
Open

fix: make ci-readiness-check.sh compatible with bash 3.2#27465
tylerbutler wants to merge 1 commit into
microsoft:mainfrom
tylerbutler:fix/ci-readiness-bash32-compat

Conversation

@tylerbutler
Copy link
Copy Markdown
Member

Description

The ci-readiness-check.sh script failed to run on macOS because it used bash 4+ features that aren't available in the bash 3.2 that ships as the default /bin/bash on macOS.

Changes

  • Replaced the declare -A associative array (used to dedupe changed packages) with a newline-delimited string deduplicated via sort -u.
  • Replaced mapfile -t with a while read loop to populate the PACKAGES array.

Validation

Verified the script passes a syntax check (bash -n) under the stock macOS bash:

GNU bash, version 3.2.57(1)-release (arm64-apple-darwin25)
syntax OK

macOS ships bash 3.2, which lacks associative arrays (declare -A) and mapfile/readarray (bash 4+ features). Replace the associative-array package dedup with a newline-delimited string deduplicated via sort -u, and replace mapfile with a while-read loop.
@tylerbutler tylerbutler self-assigned this Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (19 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Fleet Review — Clean

No issues found across the reviewer fleet for this run.

View run

@tylerbutler tylerbutler marked this pull request as ready for review June 2, 2026 19:29
Copilot AI review requested due to automatic review settings June 2, 2026 19:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants