-
Notifications
You must be signed in to change notification settings - Fork 577
refactor: Rename "docs" directory to "website" #27438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d99d31b
8ac29e9
edddb9e
188d479
927fff4
4a4e49f
c04217d
0eb05d5
16535bc
d185c26
57720da
fda7493
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: would love to rename this file too but that's a bit more intricate; I think we'd have to create the new file as a copy, go to ADO and re-point the pipeline, then delete the old file. Not sure how it would impact branches other than main... we don't tend (should?) touch the docs(website) folder in other branches, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, fair point. I think I would prefer to do that as a separate PR, but probably worth doing.
We shouldn't be making website changes on other branches - those changes wouldn't go anywhere. But I don't know if we currently build on those branches or not. Would need to be verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily for this PR but maybe this label should change too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually assuming this would expand to include things we put under the new
docsdirectory. So this would be reviewers of any documentation content (versus the website one above). Or maybe we would want those to be distinct. But yeah, probably a conversation for the future.