Remove deprecated ConsensusQueueClass export#27395
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (59 lines, 8 files), I've queued these reviewers:
How this works
|
|
This is part of:
The deprecated ConsensusQueueClass removed here was deprecated back in #26501 We have an internal tracking item which includes preparing for this removal, but the relevant code has no use of it: https://office.visualstudio.com/OC/_workitems/edit/11264625 This seems close to following our https://github.com/microsoft/FluidFramework/wiki/Beta-Break-Process. Given this was deprecated on March 2nd, in 2.90.0 ( https://github.com/microsoft/FluidFramework/releases/tag/client_v2.90.0 ), seems unused, kind of indirectly announced for planned removal in 2.100.0 (which was already released without that removal) maybe we can target this PR for 2.110.0? |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
|
|
||
| The deprecated legacy beta export of `ConsensusQueueClass` has been removed: | ||
| Use the `ConsensusQueue` singleton (which implements `ISharedObjectKind<IConsensusOrderedCollection>`) instead. | ||
| The deprecated legacy beta export of the `ConsensusQueue` type now points to `IConsensusOrderedCollection`. |
There was a problem hiding this comment.
As ConsensusQueue type is already deprecated, can we also remove it in this PR? OR should it stick around ... and we consider undeprecating.
| Remove deprecated ConsensusQueueClass export | ||
|
|
||
| The deprecated legacy beta export of `ConsensusQueueClass` has been removed: | ||
| Use the `ConsensusQueue` singleton (which implements `ISharedObjectKind<IConsensusOrderedCollection>`) instead. |
There was a problem hiding this comment.
This should reference the deprecation issue #26691
Description
Remove deprecated ConsensusQueueClass export.
Breaking Changes
The deprecated legacy beta export of
ConsensusQueueClasshas been removed:Use the
ConsensusQueuesingleton (which implementsISharedObjectKind<IConsensusOrderedCollection>) instead.The deprecated legacy beta export of the
ConsensusQueuetype now points toIConsensusOrderedCollection.Reviewer Guidance
The review process is outlined on this wiki page.