Skip to content

Remove deprecated ConsensusQueueClass export#27395

Draft
CraigMacomber wants to merge 3 commits into
microsoft:mainfrom
CraigMacomber:ConsensusQueueClass
Draft

Remove deprecated ConsensusQueueClass export#27395
CraigMacomber wants to merge 3 commits into
microsoft:mainfrom
CraigMacomber:ConsensusQueueClass

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

Description

Remove deprecated ConsensusQueueClass export.

Breaking Changes

The deprecated legacy beta export of ConsensusQueueClass has been removed:
Use the ConsensusQueue singleton (which implements ISharedObjectKind<IConsensusOrderedCollection>) instead.
The deprecated legacy beta export of the ConsensusQueue type now points to IConsensusOrderedCollection.

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (59 lines, 8 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@CraigMacomber
Copy link
Copy Markdown
Contributor Author

CraigMacomber commented Jun 3, 2026

This is part of:

The deprecated ConsensusQueueClass removed here was deprecated back in #26501

We have an internal tracking item which includes preparing for this removal, but the relevant code has no use of it: https://office.visualstudio.com/OC/_workitems/edit/11264625

This seems close to following our https://github.com/microsoft/FluidFramework/wiki/Beta-Break-Process.

Given this was deprecated on March 2nd, in 2.90.0 ( https://github.com/microsoft/FluidFramework/releases/tag/client_v2.90.0 ), seems unused, kind of indirectly announced for planned removal in 2.100.0 (which was already released without that removal) maybe we can target this PR for 2.110.0?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  290871 links
    1933 destination URLs
    2183 URLs ignored
       0 warnings
       0 errors


Copy link
Copy Markdown
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To complete the related work (#26691), ConsensusOrderedCollection and ConsensusRegisterCollection will need similar treatment. That could be in this PR or separate PRs.

Also, since I really despise as, here is a precursor PR to cleanup some related internal typing: #27497


The deprecated legacy beta export of `ConsensusQueueClass` has been removed:
Use the `ConsensusQueue` singleton (which implements `ISharedObjectKind<IConsensusOrderedCollection>`) instead.
The deprecated legacy beta export of the `ConsensusQueue` type now points to `IConsensusOrderedCollection`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ConsensusQueue type is already deprecated, can we also remove it in this PR? OR should it stick around ... and we consider undeprecating.

Remove deprecated ConsensusQueueClass export

The deprecated legacy beta export of `ConsensusQueueClass` has been removed:
Use the `ConsensusQueue` singleton (which implements `ISharedObjectKind<IConsensusOrderedCollection>`) instead.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should reference the deprecation issue #26691

@jason-ha jason-ha linked an issue Jun 5, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DDS implementation classes to be removed in v3.0

2 participants