Skip to content

Conversation

Copy link

Copilot AI commented Dec 25, 2025

Addresses code style and path inconsistencies identified in PR review after the WorkloadSim → FlowSim rebranding.

Code style fix:

  • Converted tab indentation to spaces in scripts/run_profile.py for PEP 8 compliance

Path consistency fix:

  • Updated NCCL all_reduce_perf binary path in simulator/base_parser.py:539 from /workloadsim to /flowsim

The all_gather_perf path was already updated in the original rebranding commit, but all_reduce_perf was missed.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: TerrenceZhangX <39916879+TerrenceZhangX@users.noreply.github.com>
Copilot AI changed the title [WIP] Update project naming from WorkloadSim to FlowSim Fix PEP 8 indentation and path inconsistencies from rebranding Dec 25, 2025
Copilot AI requested a review from TerrenceZhangX December 25, 2025 00:34
@TerrenceZhangX TerrenceZhangX marked this pull request as ready for review December 25, 2025 00:35
@TerrenceZhangX TerrenceZhangX merged commit e72e24a into zhangt/unified_naming Dec 25, 2025
1 check passed
TerrenceZhangX added a commit that referenced this pull request Dec 25, 2025
* Clean naming to flowsim. Update proile,simulate scripts and readme

* Update scripts/run_profile.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tests/unit/test_base_parser.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix PEP 8 indentation and path inconsistencies from rebranding (#7)

* Initial plan

* Fix indentation and path inconsistencies per review comments

Co-authored-by: TerrenceZhangX <39916879+TerrenceZhangX@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TerrenceZhangX <39916879+TerrenceZhangX@users.noreply.github.com>

* Update dockerfiles/cuda12.6.dockerfile

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update dockerfiles/cuda12.6.dockerfile

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix nameing issue

---------

Co-authored-by: Tao Zhang <zhangt@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@TerrenceZhangX TerrenceZhangX deleted the copilot/sub-pr-6 branch January 13, 2026 19:41
@TerrenceZhangX TerrenceZhangX restored the copilot/sub-pr-6 branch January 13, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants