FlightCheck: auto-open HTML report in browser after run#137
Open
amilandi wants to merge 2 commits into
Open
Conversation
Opens report.html in the default browser after FlightCheck completes. Use --no-open to suppress (e.g., in CI or headless environments). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
amilandi
force-pushed
the
amilandin/flightcheck-open-report
branch
from
33f9862 to
4051930
Compare
The BAP Admin API returns the environment type under 'environmentSku' (e.g. Production, Sandbox, Developer) not 'environmentType'. Fall back to environmentType for forward-compat. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADO task https://o365exchange.visualstudio.com/O365%20Core/_workitems/edit/7474680
Two small UX fixes for the FlightCheck experience:
report.htmlin the default browser after completing checks. Gives users immediate visual access to the full report with expandable sections, color-coded results, and remediation steps.Unknown. The BAP Admin API returns the environment type underenvironmentSku(e.g. Production, Sandbox, Developer), notenvironmentType.list_environments.pynow readsenvironmentSkufirst and falls back toenvironmentTypefor forward-compatibility. Was originally pushed to PR FlightCheck installer: fetch agent solution before running checks #134 but landed on its branch after the PR was merged — porting it here so it actually reachesmain.Changes
scripts/flightcheck/cli.py: Addedwebbrowser.open()call aftersave_results(); new--no-openCLI flag to suppress (for CI / headless use).scripts/list_environments.py: Read environment type fromenvironmentSkuwithenvironmentTypefallback.Behavior
report.html, it opens the file in the default browser.webbrowsermodule (macOS, Windows, Linux).--no-opento skip:python scripts/flightcheck/cli.py --no-open./setup, FlightCheck-only installer) shows real env types instead ofUnknown.