Remove the experimental_avx512 feature.#732
Merged
hildebrandmw merged 2 commits intomainfrom Feb 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the experimental_avx512 feature from the diskann-vector crate, as AVX-512 support has officially landed and the experimental feature flag is no longer needed. Since diskann-vector now has no features at all, it is also removed from the CI workflow's clippy-no-default-features job, which only tests crates that have features.
Changes:
- Removed the
[features]section containingexperimental_avx512fromdiskann-vector/Cargo.toml - Updated
diskann-benchmark-simdto depend ondiskann-vectorwithout the feature flag - Removed
diskann-vectorfrom the CI workflow'sclippy-no-default-featuresjob matrix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| diskann-vector/Cargo.toml | Removed the entire [features] section containing experimental_avx512 |
| diskann-benchmark-simd/Cargo.toml | Removed the features = ["experimental_avx512"] from the diskann-vector dependency |
| .github/workflows/ci.yml | Removed diskann-vector from the clippy-no-default-features job matrix since it no longer has any features to test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
==========================================
- Coverage 89.01% 89.01% -0.01%
==========================================
Files 428 428
Lines 78294 78294
==========================================
- Hits 69692 69690 -2
- Misses 8602 8604 +2 🚀 New features to boost your workflow:
|
metajack
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is no longer needed as AVX-512 support has officially landed. Since
diskann-vectorno longer has any features, this removes it from the--no-default-featuresas well.