Add Clone to Runbook.#1226
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the BigANN streaming RunBook executor cloneable so callers can parse/validate a runbook once (e.g., during input validation) and reuse it later without reparsing.
Changes:
- Added
#[derive(Clone)]toRunBook. - Added a unit-test-time assertion to ensure
RunBook: Cloneremains true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 503 503
Lines 95697 95699 +2
=======================================
+ Hits 85786 85788 +2
Misses 9911 9911
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JordanMaples
approved these changes
Jul 2, 2026
magdalendobson
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #1206, I ran into a situation where I parsed and stored the runbook during input validation rather than deferring until the benchmark is actually run.
Making it cloneable allows reuse of such a pre-parsed runbook.