[Folder 2 - Lesson 7 - notebook-covidspread] fix incorrect indexing#724
[Folder 2 - Lesson 7 - notebook-covidspread] fix incorrect indexing#724wangamber8-collab wants to merge 9 commits intomicrosoft:mainfrom
Conversation
… [2:] to [3:] to drop the correct columns and dropped the province column to ensure the function works properly
There was a problem hiding this comment.
Pull request overview
This pull request fixes incorrect data slicing in a COVID-19 spread analysis notebook that was causing non-date metadata to appear in plots. The fix adjusts the slice indexing from [2:] to [3:] to properly exclude Province/State, Latitude, and Longitude columns, and adds Province/State to the list of columns to be dropped.
Changes:
- Updated data slicing from [2:] to [3:] to exclude three metadata columns instead of two
- Added 'Province/State' column to the drop list alongside 'Lat' and 'Long' for all three dataframes
- Removed trailing whitespace in the mkframe function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@leestott Hi! I’m a freshman and fairly new to contributing to open-source projects, so I really appreciate the feedback you left earlier. I’ve gone through and addressed all the comments and made the requested changes. When you have a chance, could you take another look and let me know if this is ready to be merged, or if there’s anything else I should update? Thanks so much for your time! |
… entries
Update the slicing of the series from [2:] to [3:] because indexes 0-2 contains non-date metadata (province, latitude, longitude). The label "longitude" is included in the dataframe and appears in the plot. Additionally, drop the column "province/state" column before the function is called. This is because "province/state" contains non-date data that will cause an error when the function is called.