Improve copy command UX: keep palette open and update messaging#287
Conversation
… changed the copy messaging for other copy strings to match Commands_CopyURL
There was a problem hiding this comment.
⚠️ Not ready to approve
Several updated copy command resource strings now read like post-action confirmations (and Commands_Copy breaks composed labels), which makes pre-invocation command names misleading/inconsistent and can confuse users and assistive tech.
Pull request overview
This PR adjusts command-palette UX for “More” menu actions on issue/PR search results by changing whether the palette stays open after invoking copy vs. link actions, and by updating copy-related user-facing strings.
Changes:
- CopyCommand now returns
CommandResult.KeepOpen()and removes the previous dismissal delay. - LinkCommand now returns
CommandResult.Dismiss()after launching the browser. - Resource strings for copy commands and the copy success toast were updated to new messaging.
File summaries
| File | Description |
|---|---|
| GitHubExtension/Strings/en-US/Resources.resw | Updates copy-command labels and the copy-success toast text. |
| GitHubExtension/Controls/Commands/LinkCommand.cs | Changes link invocation behavior to dismiss the palette after opening a browser link. |
| GitHubExtension/Controls/Commands/CopyCommand.cs | Keeps the palette open after copying and removes the prior Thread.Sleep delay. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 8
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lauren-ciha
left a comment
There was a problem hiding this comment.
Thanks for taking a look! I think you only strings that need to be updated are Message_CopyCommand_Success (and maybe Commands_CopyURL).
|
ack, I'll revert the other string changes and keep `Message_CopyCommand_Success and Commands_CopyURL(this one was called out in the a11y review) |
022bcaa to
7932f30
Compare
This PR improves the user experience for copy and link commands in the "More" context menu (accessible from search result items like "Mentions me", "Assigned to me", etc.).
This PR address internal a11y bugs: 58664809, 58664669 & 58664445
Changes
CommandResult.Dismiss()toCommandResult.KeepOpen()so the palette stays open after copying, allowing users to perform multiple actions without re-navigating. Removed theThread.Sleep(1500)that was only needed to delay the dismiss.CommandResult.KeepOpen()toCommandResult.Dismiss()so the palette closes after opening a link in the browser, since the user's intent is to leave the palette.Message_CopyCommand_Successtoast to "Copied to clipboard!".