Skip to content

Improve copy command UX: keep palette open and update messaging#287

Merged
lauren-ciha merged 4 commits into
microsoft:mainfrom
chatasweetie:mention-me-more-button-a11y
Jun 17, 2026
Merged

Improve copy command UX: keep palette open and update messaging#287
lauren-ciha merged 4 commits into
microsoft:mainfrom
chatasweetie:mention-me-more-button-a11y

Conversation

@chatasweetie

Copy link
Copy Markdown
Collaborator

This PR improves the user experience for copy and link commands in the "More" context menu (accessible from search result items like "Mentions me", "Assigned to me", etc.).

This PR address internal a11y bugs: 58664809, 58664669 & 58664445

Changes

  • CopyCommand: Changed CommandResult.Dismiss() to CommandResult.KeepOpen() so the palette stays open after copying, allowing users to perform multiple actions without re-navigating. Removed the Thread.Sleep(1500) that was only needed to delay the dismiss.
  • LinkCommand: Changed CommandResult.KeepOpen() to CommandResult.Dismiss() so the palette closes after opening a link in the browser, since the user's intent is to leave the palette.
  • Resource strings: Updated copy command names to use confirmation-style messaging (e.g., "Link copied to clipboard", "Issue title copied to clipboard") to provide immediate feedback since the palette now remains open. Updated Message_CopyCommand_Success toast to "Copied to clipboard!".

Copilot AI review requested due to automatic review settings June 17, 2026 21:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

Several updated copy command resource strings now read like post-action confirmations (and Commands_Copy breaks composed labels), which makes pre-invocation command names misleading/inconsistent and can confuse users and assistive tech.

Pull request overview

This PR adjusts command-palette UX for “More” menu actions on issue/PR search results by changing whether the palette stays open after invoking copy vs. link actions, and by updating copy-related user-facing strings.

Changes:

  • CopyCommand now returns CommandResult.KeepOpen() and removes the previous dismissal delay.
  • LinkCommand now returns CommandResult.Dismiss() after launching the browser.
  • Resource strings for copy commands and the copy success toast were updated to new messaging.
File summaries
File Description
GitHubExtension/Strings/en-US/Resources.resw Updates copy-command labels and the copy-success toast text.
GitHubExtension/Controls/Commands/LinkCommand.cs Changes link invocation behavior to dismiss the palette after opening a browser link.
GitHubExtension/Controls/Commands/CopyCommand.cs Keeps the palette open after copying and removes the prior Thread.Sleep delay.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 8

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw

@lauren-ciha lauren-ciha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look! I think you only strings that need to be updated are Message_CopyCommand_Success (and maybe Commands_CopyURL).

Comment thread GitHubExtension/Strings/en-US/Resources.resw
Comment thread GitHubExtension/Strings/en-US/Resources.resw
@chatasweetie

Copy link
Copy Markdown
Collaborator Author

ack, I'll revert the other string changes and keep `Message_CopyCommand_Success and Commands_CopyURL(this one was called out in the a11y review)

lauren-ciha
lauren-ciha previously approved these changes Jun 17, 2026
@lauren-ciha lauren-ciha merged commit fedae84 into microsoft:main Jun 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants