Skip to content
This repository was archived by the owner on Feb 17, 2026. It is now read-only.

Guoye/merge embr final#3560

Open
guoli-ye wants to merge 7 commits intomasterfrom
guoye/merge_embr_final
Open

Guoye/merge embr final#3560
guoli-ye wants to merge 7 commits intomasterfrom
guoye/merge_embr_final

Conversation

@guoli-ye
Copy link
Copy Markdown

Add the EMBR code for sequence training: EMBR is WER based sequence training method, it has been used for all MS ASR production model with very good gains.

@guoli-ye guoli-ye requested a review from vmazalov January 25, 2019 19:12
#include "simplesenonehmm.h"
#include "Matrix.h"

#include <set>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need them sorted? Otherwise we can use unordered_set

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to unordered set

{
// for sorting purpose
// make sure the map is stored with keys in descending order
std::map<double, std::vector<PrevTokenInfo>, std::greater <double>> mp_score_token_infos; // for sorting the tokens in map
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not ordered_map? -- similarly in other places.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the map is for ordering purpose

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants