Add LZMA dependency for worker tasks when using libc++#7724
Open
eddyashton wants to merge 2 commits intomicrosoft:mainfrom
Open
Add LZMA dependency for worker tasks when using libc++#7724eddyashton wants to merge 2 commits intomicrosoft:mainfrom
eddyashton wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit link dependency on liblzma for ccf_tasks when building with USE_LIBCXX, to satisfy an observed transitive dependency chain (via backtrace()/libunwind on some platforms).
Changes:
- Add a
USE_LIBCXX-gatedtarget_link_libraries(ccf_tasks ... lzma)entry. - Document the rationale (libunwind built with LZMA support causing a transitive dependency).
| # worker.cpp uses backtrace() which, under libc++, resolves through | ||
| # libunwind. On systems where libunwind is built with LZMA support | ||
| # (e.g. Azure Linux), this creates a transitive dependency on liblzma. | ||
| target_link_libraries(ccf_tasks PRIVATE lzma) |
There was a problem hiding this comment.
ccf_tasks is a static library. Adding lzma as a PRIVATE link dependency is unlikely to propagate to final executables that link ccf_tasks indirectly (via ccf), which can leave the original undefined-reference problem unfixed. Please make this a usage requirement (eg, add lzma to the LINK_LIBS list for add_ccf_static_library(ccf_tasks ...), or switch to target_link_libraries(ccf_tasks PUBLIC lzma) under USE_LIBCXX).
Suggested change
| target_link_libraries(ccf_tasks PRIVATE lzma) | |
| target_link_libraries(ccf_tasks PUBLIC lzma) |
achamayou
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.