Fixing a rounding issue when converting to Julian date#9
Open
bpenev wants to merge 1 commit intomicrosoft:mainfrom
Open
Fixing a rounding issue when converting to Julian date#9bpenev wants to merge 1 commit intomicrosoft:mainfrom
bpenev wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with the division operations when converting to a Julian date. To achieve the equivalent of integer division, we need to floor each operation. At the moment, the code rounds after the entire calculation. Converting dates in July 2023 moves them one day forward (e.g. 2023-07-01 becomes 2023-07-02).